Add unique id to every threads "Hero" header

Regentl0rd

Hey, I have been messing around with Flarum, like it a lot but I have run into a small problem.

I want to add a custom image to every stickied thread's "hero" header. I was thinking the best way would be having it add a random id to every "hero" div and then make css rules for the ids generated in the stickied posts.

Is there an easier way to do this? I tried looking for an extension but didn't really find anything.

Any help would be awesome, thanks!

otakufuncom

Yes, I'm interested in this too, anything let me know

killerwin

+1 for this.

I'd like to do this as well. I've seen others style .Hero but that would apply site-wide.

Ralkage

Do you mean individual background images per hero per discussion? I assume that the image could be added via upload or URL when composing a discussion or editing the OP.

Franz

Feel free to send a PR, everyone! ?

I agree that it's worth it. No need for a "random" identifier, by the way. We already have the discussion ID. So, all you need to do is add an id attribute to the DiscussionPage component (e.g. #DiscussionPage-10593 for this one).

You could then use a selector like #DiscussionPage-123 .DiscussionHero to apply your custom styles.

killerwin

Franz I think the original idea would also allow us to style the hero for tags as well (not just for discussions).

Ralkage

Franz isn't the discussion hero going away after Beta 8? Could of sworn it was part of the Beta 8 Milestones unless it was moved to beta 9 ?

And here I thought I had the mind of a Goldfish ? ?

Franz

Ralkage I guess the ID should be added in that PR then ? Feel free to propose that.