build.sh

Kulga

I thought I'd tinker with the latest commits just for fun, but I was a little confused by the build.sh script

Particularly:

for extension in bbcode emoji likes lock markdown mentions pusher sticky subscriptions suspend tags; do
  mkdir "${release}/extensions/${extension}"
  cd "${base}/extensions/${extension}"

It tries to go into $base, then extension and tries to get a archive of it to the $release directory... but there's nothing there ($base/extension) - by design, there's a .gitignore so they all failed. So why does it try that?
I get the impression it's supposed to be run with a lot more setup then specified (cloning each extension repository into "${base}/extensions/${extension}" and then running build.sh)

Anyways, to do exactly that, I added these two lines to clone each extension and to pull it if already cloned.

for extension in bbcode emoji likes lock markdown mentions pusher sticky subscriptions suspend tags; do
  mkdir -p ${release}/extensions/${extension}
  cd "${base}/extensions/"
  git clone https://github.com/flarum/"$extension" || (cd $extension; git pull)
  cd "${base}/extensions/${extension}/${extension}"

... which solves that and then completes the build.sh without issue. The flarum install even showed up and successfully installed. But it only shows the Title and a line below it when I go to the site (no errors at all). It's the latest commit so if it's broken cause of that - no issues.

Would that be helpful? I'm not 100% sure of the purpose of the build.sh script so want to ask before making pull requests. The point is to clone the flarum repository and run ./build.sh and having it export a release to $release.. to build the latest possible, right?

Toby

Kulga I get the impression it's supposed to be run with a lot more setup then specified (cloning each extension repository into "${base}/extensions/${extension}" and then running build.sh)

Kulga The point is to clone the flarum repository and run ./build.sh and having it export a release to $release.. to build the latest possible, right?

Both correct. Hold off on any pull requests though, because I'm planning to revamp the build script in the coming days. I'll keep this in mind.

Kulga But it only shows the Title and a line below it when I go to the site (no errors at all). It's the latest commit so if it's broken cause of that - no issues.

The latest commit should be working... Are you sure there's no error in the JavaScript console?

Kulga

Toby
I see this in the inspector (I need to try looking for browser errors more, I'm very used to server error logs!)

TypeError: (intermediate value)(...) is not a function forum-V4ExblXBeqePBfm7.js:1:0
TypeError: System.get(...) is undefined bleedingflarum.xyzz.work:73:22
window.controllers is deprecated. Do not use it for UA detection. nsHeaderInfo.js:412:0
The Web Console logging API (console.log, console.info, console.warn, console.error) has been disabled by a script on this page.

The debugger spits out a huge amount of data for one of the errors. 1st error and a smaller amount for the System.get (guess it's not defined yet)

          try {
            var app = System.get('flarum/app').default;

            babelHelpers._extends(app, {"preload":{"data":[{"type":"forums","id":"1","attributes":{"title":"Bleeding Flarum","description":"","baseUrl":"http:\/\/bleedingflarum.xyzz.work","basePath":"","debug":true,"apiUrl":"http:\/\/bleedingflarum.xyzz.work\/api","welcomeTitle":"Welcome to Bleeding Flarum","welcomeMessage":"This is beta software and you should not use it in production.","themePrimaryColor":"#4D698E","canView":true,"canStartDiscussion":false,"allowSignUp":true,"defaultRoute":"\/all","minPrimaryTags":"1","maxPrimaryTags":"1","minSecondaryTags":"0","maxSecondaryTags":"3"},"relationships":{"groups":{"data":[{"type":"groups","id":"1"},{"type":"groups","id":"2"},{"type":"groups","id":"3"},{"type":"groups","id":"4"}]},"tags":{"data":[{"type":"tags","id":"1"}]}}},{"type":"groups","id":"1","attributes":{"nameSingular":"Admin","namePlural":"Admins","color":"#B72A2A","icon":"wrench"}},{"type":"groups","id":"2","attributes":{"nameSingular":"Guest","namePlural":"Guests","color":null,"icon":null}},{"type":"groups","id":"3","attributes":{"nameSingular":"Member","namePlural":"Members","color":null,"icon":null}},{"type":"groups","id":"4","attributes":{"nameSingular":"Mod","namePlural":"Mods","color":"#80349E","icon":"bolt"}},{"type":"tags","id":"1","attributes":{"name":"General","description":null,"slug":"general","color":"#888","backgroundUrl":null,"backgroundMode":null,"iconUrl":null,"discussionsCount":0,"position":0,"defaultSort":null,"isChild":false,"isHidden":false,"lastTime":null,"canStartDiscussion":true}}],"session":{"userId":0,"token":null},"document":{"links":{"first":"?page%5Boffset%5D=0"},"data":[]}},"locales":{"en":"English"},"locale":"en"});

                          System.get('locale');
                          System.get('bbcode/main');
                          System.get('emoji/main');
                          System.get('likes/main');
                          System.get('lock/main');
                          System.get('markdown/main');
                          System.get('mentions/main');
                          System.get('sticky/main');
                          System.get('subscriptions/main');
                          System.get('suspend/main');
                          System.get('tags/main');

I made one small pull request prior to your post, feel free to ignore it 😉 (But then, you've already accepted it lol)

Toby

The errors are due to an out-of-date flarum-gulp npm package (relevant commit). Try updating and recompiling all the JavaScript 🙂

Kulga

Ok! It works! Thanks Toby

So after finding the source flarum-gulp files and updating it, I had to install a bunch more extensions. This may be useful if you're doing this (dev environment - not normal install) I had to attempt a compile for each one of these lol - waiting for each error.

Extra extensions:

gulp-livereload
gulp-concat
yargs
gulp-uglify
gulp-if
gulp-babel
gulp-cached
gulp-remember
streamqueue
babel-plugin-object-assign

Toby

Kulga That's weird – flarum-gulp includes all of those as dependencies, so they should be installed automatically. Did you use npm update? Globally or locally in each of the JS folders?

Kulga

Toby I used npm update - but it stayed with the old version so I went for the source (github) and manually installed them. I also tried removing the files then reinstalling -> npm install -g flarum-gulp
But it was still the old one :\

Should note I'm using Debian 7 with npm 2.11.3
There's a distinct possibility I might just have a old version being packaged.

Toby

Kulga My bad – seems I had neglected to run npm publish. Just published version 0.1.1 🙂

Kulga

ok. I deleted the git repo and installed flarum-gulp. Success! It's definitely asking for those extensions now.

Kulga

@Toby Both correct. Hold off on any pull requests though, because I'm planning to revamp the build script in the coming days. I'll keep this in mind.

I actually ended up rewriting the whole thing as I wanted it to be a little more expandable for my own use. You can use it if you'd like, otherwise I won't do a pull request as requested -
Feel free to see here
I added a number of things

Separation of updating, copying over files and compiling
Easier to designate what extensions to compile (One variable at top)
Reports commit hash of each updated repo
Getopts flags for designating source flarum files, compiled flarum files and where to export the zip + tarball
eg -e ~/ will export tarball and zip to /home/$USER, -s /home/foo/files/flarum will designate that as where the source files are.. etc. Try -h for more.
I use sub-processes to keep things relative.
Can be run from within flarum/flarum or by itself (it'll clone everything). If you copy the file and run it without flags it will clone the flarum repository in ./, use that as the source, use mktemp -d (/tmp/tmp.fsdafgsgd) as the compile location and /tmp/flarum_date.zip/tar.gz as the export location.

As long as you have the dependencies (bower, gulp, etc) installed, compiling a dev release is now literally one-step. ./fullbuild 😃

Franz

Kulga Thank you very much, it's interesting.

I cleaned up the indentation and uploaded it to the repository for now; can be used as inspiration by @Toby.

That said, can it easily be used to update the code of all installed extensions and their dependencies?

Kulga

Franz You mean like after making changes to the repos? Yeah.
In fact, I was working on incremental ones - where as long as source and compile locations don't change, it will only compile that specific part (like flarum/likes) if the hashes change.

Kulga

Getting a dev release (provided you have gulp + composer, etc installed and working) now takes this:

git clone https://github.com/flarum/flarum && flarum/fullbuild.sh

and you should get a /tmp/flarum_date.tar.gz file ready for usage (which I just tested on my local computer... and my VPS.. both work! 😃)

Franz

Kulga Does that create a build or prepare the working copy of the repo for usage (asset compilation etc.)? If the latter, does it do so without the --production flags?

Kulga

Franz It's based heavily on the original build.sh script so it copies much of the compiling scripts.
If you run it, it will at the end export a zip and tar.gz to /tmp. If you extract this, it is a functioning release (much like the beta)
So I believe that's a working copy with --production.
However, since I split them up into functions (updating, copying over, compiling, etc), it wouldn't be too hard to compile in different ways post updating the repos.

It does this by default

Clones the git repo for flarum if not in one.
Clones core, then each extension into flarum/core and extension/$extension

It copies the files over to the compiling area with some variation of

   git archive --format tar --worktree-attributes HEAD | tar -xC "$compiled_flarum/extensions/$extension"

It then compiles the core and extensions as per the original script
Then sets the permissions and exports a tarball.