Extention to mark discussion as frontpage

clarkwinkelmann

AbubakarLawalAlawAbula nice. I suggest you always use namespaced strings with add() on control lists in javascript. In case another extension calls itself with the same name this will prevent issues. Also you have an item called sticky which I believe you copy-pasted from another extension. You might want to rename it to be sure there's no problem between your ext and the core sticky extension ?

AbubakarLawalAlawAbula

clarkwinkelmann yes i did, i will make d change

AbubakarLawalAlawAbula

Pls can anyone help me with quering a sort

export default function () {
    extend(DiscussionList.prototype, 'sortMap', function (map) {
        map.frontpage = '-frontdate';
       
    });
}

how do i make it select frontdate where frontpage is true. @luceos @clarkwinkelmann

clarkwinkelmann

AbubakarLawalAlawAbula you want to filter the api results ? You'll need to add something with PHP to do the filtering on the database query.

The sticky extension source code will probably give you all the details you need.

AbubakarLawalAlawAbula

clarkwinkelmann aiit thanks

AbubakarLawalAlawAbula

clarkwinkelmann thank you for your help, am really new to mithril , so am finding somethings difficult for now. i think i got a way to filter the result but don't know how to pass it e.g

extend(DiscussionList.prototype, 'requestParams', function(params) {
    params.filter.q = frontpage => true;
  });
}

how do i pass
params.filter.q
to filter all discussions with frontpage.

clarkwinkelmann

AbubakarLawalAlawAbula I don't think the matter at hand has anything to do with Mithril ?

You're extending a method with Flarum extend helper. Then the params are just a plain javascript object that will be used to build the request.

I don't know if you already implemented the backend code that will handle that new request parameter ?

You could use something like params.filter.frontpage = 'true' if you wanted to use /api/discussions?filter[frontpage]=true.

If you want to pass a special keyword as part of the q parameter this will be a bit more complicated, both to inject and read if you don't want to break the base search feature.

The goal is to only return the "frontpage" discussions on whichever page you're overriding requestParam ? Keep in mind that if you don't add a condition within your extend code, all discussions lists will get that parameter (front page, tag discussions, user discussions, ...). For example you can access app.current to know which page you're on inside the extended method.

AbubakarLawalAlawAbula

clarkwinkelmann I really appreciate your time, pls explain how i can handle such request in d backend, a brief is all i need.. thank u very much

clarkwinkelmann

I just had a quick look at core extensions and it looks like the preferred way of filtering the results seem to use a search gambit.

Check https://github.com/flarum/flarum-ext-subscriptions/blob/master/src/Listener/FilterDiscussionListBySubscription.php#L35 and https://github.com/flarum/flarum-ext-subscriptions/blob/master/src/Gambit/SubscriptionGambit.php on how to add a gambit.

Then here's how the gambit is used in the search query when browsing the follow page https://github.com/flarum/flarum-ext-subscriptions/blob/master/js/forum/src/addSubscriptionFilter.js#L21

AbubakarLawalAlawAbula

clarkwinkelmann thank u bro, will check and give u feedback.

AbubakarLawalAlawAbula

clarkwinkelmann Thank u, result is now filtered, but is filtered for all sort, is there a way to filter only frontpage
frontd
frontd2

	if (sort == front) {

	params.filter.q = ' is:frontpage';
	
	}
  });```

clarkwinkelmann

AbubakarLawalAlawAbula great !

I gave you a hint above, you can get current page with app.current. This can probably be used with instanceof and the class of the homepage. Not sure if that value will already be updated when the filter is applied though...

Another solution would be to do as the subscription extension does (with params.filter). Add an additional property to the class so you know when you're in the right class. It's a bit different though because they were creating their own page, but you could extend the init method of whatever page you want it to apply to and do the same.

EDIT: be careful you're overriding the q attribute in the code you just posted. this might prevent using the search on that page ! Do the same as the subscription extension does to keep the existing q value if it is set.

AbubakarLawalAlawAbula

clarkwinkelmann thank u, will do as u advice

AbubakarLawalAlawAbula

clarkwinkelmann my only problem now is to place Frontpage at the top of latest in the dropdown, rearraging the map will be the fastest way, but dont know how to rearrange an object in javascript, any help?

AbubakarLawalAlawAbula

Successfully done, i checked if this.pros.params.sort ==='front'

AbubakarLawalAlawAbula

i got it, i deleted each property and reassigned it, e.g delete map.latest, but i noticed the first property returns without a filter. e.g when map.front is the first property the url is just /, but others after have the url is /?sort=newest . What am i missing?

« Previous Page