Edit Cutom Header Actually does not put code in the head tag

MikeJones

I tried adding some code to my header using the edit custom header and it just placed the code right below the header. Is this a bug? It actually put it in my body element:

  </head>

  <body>
    <link rel="manifest" href="https://www.seekadventure.net/manifest.json">

The manifest link is the code I dropped into the custom header int he appearance part of the admin page.

arda

MikeJones I didn't see this issue, it worked perfectly for me.

I'm not sure about the body part though, the stuff I put inside the custom header area worked, not sure about where it put ?

arda

MikeJones Possible, let me try it on my local Flarum installation and tell you.

MikeJones Seems like this is an issue.

My custom header code:

Code location:

It doesn't affect it's action though, it's working fine for me.

jordanjay29

MikeJones . Is this a bug?

It's known, but I don't think it's considered a bug.

The suggestion at the moment is to use an extension if you have code that needs to reside in the <head> tag. The reasoning is that it's far easier to screw up your site with malicious code in the head tag, so requiring an extension means that it takes someone who knows what they're doing and isn't just cutting/pasting scripts carelessly. It's also easier to fix with a composer command, rather than having to dive into the database to remove the code.

MikeJones

arda that makes it more interesting then. Could an extension be effecting where this is placed?

MikeJones

clarkwinkelmann It's the expected behavior. It's custom header, not custom head ?

That makes sense to m enow lol

jordanjay29 The suggestion at the moment is to use an extension if you have code that needs to reside in the <head> tag.

That makes sense. I was trying to throw some code together real fast for the PWA so I could make a default manifest etc to share for someone to throw into an extension.

clarkwinkelmann

It's the expected behavior. It's custom header, not custom head ?

That's also what says the text just above the button to customize it:

Custom Header

Add HTML to be displayed at the very top of the page, above Flarum's own header.

Frink

MikeJones You could try using <head> and </head> around the code, although im not sure if that might just make another <head> ?