Url on oauth2

Staszek

I just noticed, that in handle method of oauth2controller, redirectUri is the one that was in request header, and not like in config.php. Is it as expected? I'm asking, because it makes problem, then I want to have my Flarum instance to be accessible on different URL, that is in config.php (I have a proxy server in between, and can't set preserveHost in Apache). When I changed this Uri for testing, it works with Url from config.php plus for example /auth/google.

luceos

You can set the value of url in your config.php dynamically using php.

Staszek

Yes, but the point it that URL value from config.php it is not used in AbstractOauth2Controller. In handle method it uses uri of the request for $redirectUri, instead of building it from Url get in config.php, and tail from uri from request (eg. /auth/google like in google oauth controller). Is it as expected? Because it breaks oauth login, when someone has proxy server in front of the one with Flarum, and hostnames are different.

luceos

That's a very unusual edge case. The redirect url is always used to verify the signature of an oauth authorization. I think the error is in generating the url to the provider.