Beta 8: email not translated

peopleinside

Hi to everyone.
I recently find some issues on the Italian translation and thanks to @Nearata issues was fixed BUT seems post, mention emails still be in English.

Seems on the core there are just three email that can be translated:

account activation
email edit(s)
password reset

Will be very important to be able to translate also all other email when there are a new reply, mention, etc or we will have a translate forum but not emails.

@matteocontrini i tried to subscribe to some post on your Italian community for understand if, in the previous Beta, emails are translated to the Italian or not. I am unable to see email sent in Italian on my Beta 8 install, just password reset and maybe (not tested) other two typos of emails are translated.

Is this a bug or Beta 8 doesn't support email translation? Will be also useful for the future be able to customize email from the admin backend or maybe decide a signature email where can be more info about spam and about how to stop email notifications.

Please let me know if this issue should be GitHub reported on the Flarum core, thank you!

matteocontrini

peopleinside @matteocontrini i tried to subscribe to some post on your Italian community for understand if, in the previous Beta, emails are translated to the Italian or not. I am unable to see email sent in Italian on my Beta 8 install, just password reset and maybe (not tested) other two typos of emails are translated.

In my case I manually edited some source code files to translate email messages and fix some other issues.

For example, the subscriptions extension has the email template hard-coded: https://github.com/flarum/subscriptions/blob/v0.1.0-beta.8/views/emails/newPost.blade.php

peopleinside

jordanjay29 Thanks, i hope to see this extension in Beta 8. Maybe will be useful also for English admins be able to customize email template but this maybe in future. Can we add also feedback tag here?

matteocontrini thank you! Last question, how you customized the subject [new message] -> [nuovo messaggio] ?

jordanjay29

You can use Flagrow Linguist to translate email templates. It's not ready for Beta 8 yet, but when it is it should provide a more sustainable interface to edit email templates than doing so manually.

matteocontrini

jordanjay29 are you should that would work? 🤔 is it able to override Blade PHP templates?

peopleinside here:

vendor/flarum/flarum-ext-subscriptions/src/Notification/NewPostBlueprint.php

peopleinside

matteocontrini jordanjay29 override every update email template is a little bit big work.
Flarum core should support ( i think ) in the future some settings to customize email. For me is important to give information for all user that want stop email notification this to avoid they flag email as spam because doesn't find the quick links for unsubscribe.

Maybe i can tag @clarkwinkelmann about

jordanjay29 You can use Flagrow Linguist to translate email templates. It's not ready for Beta 8 yet, but when it is it should provide a more sustainable interface to edit email templates than doing so manually.

and

jordanjay29 That might be a feature request to suggest for Linguist.

Anyway i think the email template customization issue should be discussed in core of Flarum maybe with a GitHub topic. Why? If a website want customize text or insert a sentence will have all time there are an update of Flarum do the manual edit again to files.

jordanjay29

matteocontrini are you should that would work? 🤔 is it able to override Blade PHP templates?

Hmm, no, you're right, it won't. 🙁

That might be a feature request to suggest for Linguist. Or to Flarum's Core, so Linguist can pick it up natively.

matteocontrini

jordanjay29 I remember a very old discussion about email templates, where the conclusion (last comment) was to keep Blade templates, in order to be able to provide styled HTML email messages in the future. So the way to have emails translated would be to inject every sentence or so, picking it from translation file.

I'm wondering if there's already an issue for that, among the 300 open issues 😅

jordanjay29

peopleinside Probably better to suggest it for Linguist to attempt. Or another extension. I wasn't aware of that old discussion but the conclusion makes sense.