Beta 8 - Formatting buttons do not work

GameBurrow

Formatting buttons on the bottom of post do nothing. Same is happening on my own forum and here actually.

Emoji and mention buttons are the only one that work.

datitisev

Are there any errors in the JavaScript console? (F12 in most browsers)

GameBurrow

@datitisev As soon as I open the editor, this appears yes:

datitisev

Hm, seems like the issue is because the toolbar breaks the guidelines found at https://html.spec.whatwg.org/multipage/custom-elements.html#custom-element-conformance.

The element must not gain any attributes or children, as this violates the expectations of consumers who use the createElement or createElementNS methods.

Not sure why it would be breaking them, though, because as far as I can tell the requirements are not broken, and were actually fixed by Toby. See the file at https://github.com/github/markdown-toolbar-element/blob/master/index.js#L15.

🤔

Franz

datitisev Not sure how the browsers are detecting this in the first place... maybe they are confused because the style-setting callback registration is in the constructor as well? But this is just wild guessing. 😕

This issue should definitely be reported at the library's repository.

GameBurrow

Okay, intersting fact
Works in Firefox, Edge and Chrome, but doesn't work in Vivaldi (Chromium based browser)

datitisev

GameBurrow Yep! I can reproduce in Vivaldi 2.1.1337.36 and 2.1.1337.51 (latest stable).

alexanderlill

It seems that all buttons except the ones for smileys and @-mentions still do not work.
I see the following error on the console when the reply window is opened (after clicking on "Reply"):

Uncaught TypeError: Failed to construct 'HTMLElement': Please use the 'new' operator, this DOM object constructor cannot be called as a function.
    at Object.construct (reflect.js:2099)
    at e.y (index.esm.js:14)
    at e (index.esm.js:37)
    at new e (index.esm.js:78)
    at mithril.js:686
    at M (mithril.js:872)
    at A (mithril.js:1000)
    at O (mithril.js:630)
    at A (mithril.js:989)
    at mithril.js:709

Franz

alexanderlill That's actually a new issue, and we're aware of it. Expect to see it fixed within the next two or three days.