JasperVriends Then I'll need to add an or to the if statement so it's still compatiable for the old plugin-version.

If you release a new version of this extension, it's perfectly okay to drop support for extensions that are no longer maintained..

      • [deleted]

      • Post #274
      • Edited

      luceos I agree with this. The previous incarnation of best answer was broken before being brought into the FoF namespace, so there seems to be little point in supporting what is now considered legacy. Perhaps make a note in the upgrade ?

        Easier would be to add fof/best-answer under suggests and the other extension under conflict.

        See https://getcomposer.org/doc/04-schema.md#conflict for conflict and the full composer schema. These changes only apply to the version tagged with this information, which makes it incredibly powerful to abandon a dependency you previously used.

        a month later

        Hi, I have been using this extension for almost 2 years but I don't know why every time I test this with structured data i have a lot of errors in headings have this (String length of headline must be in range [0, 110]) in the logo I have this (there is a link with image but I have this error anyway) A value for the url field is required. I have this one too dateModified The dateModified field is recommended. Please provide a value if available. mainEntityOfPage The mainEntityOfPage field is recommended. Please provide a value if available.

        Is there a solution for this..?

        a month later

        Alshain Oh, my God. How do you modify the layout of your forum? I love this layout.

          5 days later

          The robots.txt unable to work properly
          `public function process(Request $request, Handler $handler): Response
          {
          $method = $request->getMethod();
          $uri = $request->getUri()->getPath() ?: '/';

              $routeInfo = $this->getDispatcher()->dispatch($method, $uri);
 
    switch ($routeInfo[0]) {
        case Dispatcher::NOT_FOUND:
            throw new RouteNotFoundException($uri);
        case Dispatcher::METHOD_NOT_ALLOWED:
            throw new MethodNotAllowedException($method);
        case Dispatcher::FOUND:
            $handler = $routeInfo[1];
            $parameters = $routeInfo[2];
 
            return $handler($request, $parameters);
    }
}`

            Hello, Thanks for your great work. but i wanna know if it is possile that setting twitter:image meta as summary_large_image or summary by detecting the size of image, or just give us a option?

            Yeah, as @Alshain said, there are duplicated contents with various URLs that should return 404.

            Anyway is something related to Flarum itself, not to this plugin. Flarum SEO itself is a total mess. This plugin helps a little but still tons of SEO issues.

            21 days later

            robinodds No idea why that is 🤔 I don't see any mention to '0.4-beta' in the extension or composer.json?

            I'll try to reproduce it and update the extension this weekend.

            alfathso This update will also fix your issue

                  I suppose Packagist accepts non-semver-compilant versions.

                  If we read the semver spec, 0.4-beta is not a valid version https://semver.org/

                  A normal version number MUST take the form X.Y.Z

                  But because it's a valid version in Packagist, I think the correct approach here would be for Admin Dashboard to use Composer's normalize() function https://github.com/composer/semver/blob/master/src/VersionParser.php#L102 on the version before using it as semver.

                    clarkwinkelmann It definitely should not fail hard when it finds one invalid version. At worst case 0.4-beta and similar versions should be ignored.

                    I've already implemented finding last version for my Weblate initiative (based on list of tags from Github/Gitlab, but it should work with Packagist data too), you may want to take a look: https://github.com/rob006-software/flarum-translations-builder/blob/60946656b1b63ffd3e89bd6c41c3353a34568eef/components/extensions/ExtensionsRepository.php#L270-L312

                      I have a tiny issue with your addon, it is complaining about the sitemap addon. I do have the fof Sitemap addon installed, enabled, and the Sitemap is there, but it still thinks that I have not set it up. I have tried reinstalling both addons, but the issue does not go away. Is there a way you could help me with this?

                      Thank you!

                        TommyTran732 Looks like the extension is looking for the flagrow-sitemap ID. When you installed flagrow/sitemap, I assume it installed the fof version as the GitHub repository was transferred, so Packagist is retrieving the FriendsOfFlarum repository now.