Using a Different MonoLog handler / location

meezaan

Hi Folks,

Thank you for creating something pleasant to work with!

I'm deploying Flarum in a Docker Swarm / Kubernetes environment so I really need may logs to be coming to stdout and / or stderr (for various reasons, consistency and performance being prime candidates).

In Flarum\Foundation\InstalledSite all logs are currently being forced into the storage/logs using MonoLog's RotatingFileHandler.

I'd like to make this configurable, so if we pass a parameter in the config file allowing for a Monolog Log Handler type and / or location, we can control where the logs go.

Are you happy for me to make such a change on a fork and just raise a Pull Request? Is someone else already looking into something like this (I couldn't find anything on the community here) and I can perhaps help with it as I would like to do this today or tomorrow?

Thank you.

Meezaan-ud-Din

luceos

The easiest way would be to write a custom (local) extender (implementing the ExtenderInterface) that adds the StdOut for logging when the logger is being resolved:

$container->resolving('log', function (\Monolog\Logger $logger) {
    // do your magic
    return $logger;
});

meezaan

Thank you @luceos happy to do that - but surely this should be a standard feature - deploying in a containerised environment is becoming commonplace.

luceos

Everything should be a standard feature if you look from the right angle 😉

meezaan

🙂 but logging is not really a feature or an extension. Besides. this is only about the 'location' of the logs which should be config only (like the location of the storage directory, for instance).

meezaan

Hi @luceos I've done this but interesting the nothing inside $container->resolving('log') fires.

So my Extender looks like this:

use Flarum\Extend\ExtenderInterface;
use Illuminate\Contracts\Container\Container;
use Flarum\Extension\Extension;
use Monolog\Formatter\LineFormatter;
use Monolog\Handler\StreamHandler;
use Monolog\Logger;

class Log implements ExtenderInterface
{
    public function extend(Container $container, Extension $extension = null)
    {
        //var_dump($container->resolved('log'));exit;
        $container->resolving('log', function (\Monolog\Logger $logger) {
            //var_dump('inside');exit;
            $handler = new StreamHandler('php://stdout', Logger::DEBUG);
            $handler->setFormatter(new LineFormatter(null, null, true, true));
            $logger->pushHandler($handler);
            return $logger;
        });
    }
}

In extend.php, I'm doing this:

return [
    // Enable logging to console instead of disk
    new Log()
];

Interestingly, the var_dump always fires as true, which means by the time it gets here, the log alias has already resolved. So the resolving never fires.

What am I doing wrong?

Thank you very much for your help!

luceos

Check this: https://lornajane.net/posts/2014/logging-to-stdout-with-monolog

Monolog has an in-built stdout and stderror handler if I'm not mistaken 😉

meezaan

That is what I'm using, the StreamHandler. But $container->resolving('log', ...) never actually fires because by the time it gets to the Extender, the log alias has already resolved.

meezaan

The:

var_dump($container->resolved('log'));exit

always returns true. But:

var_dump('inside');exit;

is never executed.

meezaan

Thank you @luceos for responding to this on discord.

The following works.

$container->extend('log', function() {});