Why editing core files don't take effect?

SampaioLeal

I'm trying to just remove the "change email" button from user settings page.
I found the file: SettingsPage.js
So, i commented all the section with the Change Email button, but anything happens. The button still here

jordanjay29

SampaioLeal Probably because the js is still using the pre-generated files. Use Clear Cache function in the Admin Dashboard or run php flarum cache:clear in terminal.

In general, editing core files is not advised, since these changes will not persist between upgrades and may be overwritten by composer (anything in the vendor file is treated as fungible). The better way is to use an extension (or a simple extend.php like this one) to enact your changes.

jordanjay29

SampaioLeal So, i commented all the section with the Change Email button, but anything happens. The button still here

This is what you described. Can you paste it in here (surround it with three backticks ``` like so for better formatting)?

SampaioLeal

jordanjay29 So how i do this in extend.php?

SampaioLeal

jordanjay29 Clear cache dont worked ;-;

jordanjay29

SampaioLeal We'll likely need to see the code you used to answer both of those questions.

luceos

Editing these component files won't help without compiling it anew to the dist folder using npm.

SampaioLeal

luceos so i have to create an extension? but i dont want to learn to create an ext from zero. I think that extend.php solve this problem. So how can my code get?

clarkwinkelmann

SampaioLeal but did you recompile the core javascript ? Flarum only loads the compiled files, and you're editing the source. You didn't answer luceos message about this above 😉

Creating your own extension won't be much more complicated than updating core and recompiling it, it's exactly the same system. Regarding your question about extend.php, it's the exact same system as writing an extension, but it's is just a shortcut to not create an extension directory and link it with composer. But with just extend.php I don't think you can insert javascript as easily as with your own extension.

jordanjay29

SampaioLeal Please post the code you used.

SampaioLeal

jordanjay29 i don't have a code, that's the problem

SampaioLeal

jordanjay29 the file is: /vendor/flarum/core/js/src/forum/components

accountItems() {
    const items = new ItemList();

    items.add('changePassword',
      Button.component({
        children: app.translator.trans('core.forum.settings.change_password_button'),
        className: 'Button',
        onclick: () => app.modal.show(new ChangePasswordModal())
      })
    );

    /* items.add('changeEmail',
      Button.component({
        children: app.translator.trans('core.forum.settings.change_email_button'),
        className: 'Button',
        onclick: () => app.modal.show(new ChangeEmailModal())
      })
    ); */

    return items;
  }