Is there a way to always have the sub-tags visible?

alx

For example have
Support
- Installation
- Upgrading
- Hosting

Without clicking on Support

clarkwinkelmann

alx it's not a built-in feature, and would likely require forking the Tags extension to be changed.

clarkwinkelmann

To follow up your question in the duplicate discussion:

The line responsible for showing or hiding children is here https://github.com/flarum/tags/blob/v0.1.0-beta.8.2/js/src/forum/addTagList.js#L39

It's probably not easy to change via an other extension and would require forking the whole tags extension, for example by cloning it to a workbench folder (see dev tutorials for that) and editing the code there.

I don't recommend editing any file in vendor as the changes will be overwritten when composer installs or updates packages.

alx

clarkwinkelmann Could I fork the extension, delete the line, uninstall tags and reinstall the modified tags extension?

clarkwinkelmann

alx that's the gist.

This should be a good resource on how you can create a clone of the extension locally. Use the same steps but instead of creating a new extension, clone flarum/tags to the workbench and edit its source code there https://discuss.flarum.org/d/1608-extension-development-using-composer-repositories-path

alx

clarkwinkelmann Didn't work.

Here's what I did:

Found the tags extension in my file manager. Deleted everything.

Downloaded the github version, modified it.

Upload it back to public_html/vendor/flarum/tags

Turn off the extension, turn it back on.

The website still works as before so it makes me believe that it may not be that line of code that had to be deleted?

alx

clarkwinkelmann I was confused because the line of code you pointed to was under "sortTags(tags)"

What I would like to happen is to simply have the tags always active, that way all the subtags are constantly showing.

clarkwinkelmann

alx line 38 sorts the tags. Line 39 filters which tags are visible. The test on that lines shows all tags with a position (aka primary tags) that have either no parent, or are children of the active parent, or their are children of the parent of the currently active tag. Removing && (!tag.isChild() || (currentTag && (tag.parent() === currentTag || tag.parent() === currentTag.parent()))) should show all primary tags whether they are active or not.

After changing the javascript source code you need to recompile the dist files. You need to npm install the dependencies and run the npm run build command.

alx

clarkwinkelmann Do I recompile locally or on ssh?

Also where do I recompile? in public_html/vendor/flarum/tags?

clarkwinkelmann

alx the npm commands must be run in the js folder of the extension. You can do that either locally or on the server. Flarum only loads the dist files.

Again, I'd recommend using a workbench folder and not edit anything directly in the vendor folder. Sending the files via FTP/SSH is also possible once the extension has been linked to the workbench folder. That would be the safest way.

alx

clarkwinkelmann Got it working!

clarkwinkelmann What line of code is in charge of removing the small colored squares for sub-tags?

Prosperous

alx Nice work! Can we consider this discussion as solved?

alx

Prosperous Yes however I just want to know "What line of code is in charge of removing the small colored squares for sub-tags?" before 🙂

clarkwinkelmann

alx the square is the linkbutton's icon (fas fa-th-large defined higher in the file). The easiest would be to hide it or make it transparent via CSS if you want to get rid of it.

alx

clarkwinkelmann I actually want to do the opposite! keep it for the subtags and the primary tags.

alx

clarkwinkelmann Got it, don't worry 🙂

alx

How hard is it to modify?

clarkwinkelmann

alx I suppose the way discussions are counted is by design.

Changing the count method should be doable, but I don't know how difficult it can be.

For reference the existing code for the feature is here https://github.com/flarum/tags/blob/master/src/Listener/UpdateTagMetadata.php

alx

Looking to always have the sub-tags showing