Listen event

NikoVonLas

Sry for stupid question, but how i can listen event from root extend.php?
Closures like in extensions dont work.

Franz

NikoVonLas Events are more or less considered private - we want to cover those use-cases with extenders in the (near) future. Those may then use events as implementation detail, but don't have to.

That said - what exactly are you trying to implement? I'll make sure that use-case is covered by extenders.

datitisev

NikoVonLas Closures like in extensions dont work.

We kept them for extensions for backwards compatibility, but to use closures in the root extend.php, you'll need to wrap it around new Extend\Compat(...)

return [
    new Extend\Compat(function (Dispatcher $events) {
        // ...
    })
];

NikoVonLas

Franz Just try implement field of FoF\Masquerade extension as Display name. I can do this with edit extend.php of extension, but this bad practice.

Itsick

NikoVonLas
what about somthing like here?

luceos

datitisev \Flarum\Extend\Compat to be precise.

NikoVonLas

datitisev Thanks!

NikoVonLas

Itsick Exactly that i was trying to implement.
My code:

use Flarum\Extend;
use Flarum\Event\GetDisplayName;
use Illuminate\Contracts\Events\Dispatcher;
use FoF\Masquerade\Answer;

return [
    new Extend\Compat(function (Dispatcher $events) {
        $events->listen(GetDisplayName::class, function($user){
	        $answer = Answer::where([
	           	'user_id' => $user->user->id,
	          	'field_id' => 1
	        ]);
	        $res = $answer->get(['content'])->first();
	        return $res && $res->content ? $res->content : '';
	    });
    })
];

clarkwinkelmann

NikoVonLas beware of performance issues.

As we discussed on Discord with Drillbert (I don't think you are thr same person ?), a single request could include many users. For example an API call for the list of discussions could contain discussion author and last reply author. In normal case I think 20 results are asked, so up to 40 users possible. The API allows up to 50 discussions requested at once, so up to 100 users.

This means a lot of database queries in a single API request.

The ideal solution would employ Eloquent relationships to load all of the data at once, but it requires adding code in multiple other places of the Flarum API. Another solution would be to cache the display names so fetching does not require a database query every time.

Maybe I'm over-thinking and your performance is fine, I'm curious to know how it performs for you.

NikoVonLas

clarkwinkelmann Not same person, yep. I dont think about that, realy simplest way - just add display_name to user db and change code to:

new Extend\Compat(function (Dispatcher $events) {
    $events->listen(GetDisplayName::class, function($user){
        return $user->display_name;
    });
})

But thats requires changes in masquerade extension.
I can do tis feature with pull request if you want of course.
I think, this may be just a option in extension settings. Without edit root extend.php of course.