Post Editor is a CPU hog

antonjw

When I'm writing or editing a post, my CPU goes proper, proper batshit. CPU for browser goes to over 120%. It's very obvious and consistent.

This is in Firefox 44 on Mac El Capitan. I'll try it out on my other browsers. But this can't be right?

jordanjay29

What extensions do you have installed on Flarum?

antonjw

jordanjay29 I don't have it installed anywhere, jj.

I'm talking about here on flarum.org.

Kulga

Firefox 44 Linux Mint

I can't verify 120% - but I am getting a 40% jump and holding steady 40-48% with composer window open on this forum at least. Got a few windows open so will need to isolate it a bit.

antonjw

Kulga I can't verify 120% - but I am getting a 40% jump and holding steady 40-48% with composer window open on this forum

Yes, I imagine it will vary depending on your machine. Mine is a 4.5 yr old MacBook Air. So that's 120% of an old CPU.

jordanjay29

antonjw Ahh, thanks. I'm not getting that same kind of significant jump on Windows 10 with Firefox 44, just a 5% increase from 10-15% CPU usage.

antonjw

jordanjay29 Mine goes from Firefox ticking over at 30-50%, to the whopping 120% on writing / editing, and my machine going from tranquility to sounding like heathrow.. :/

Kulga

antonjw submit a bug report?

I did a quick review and search for "cpu" but didn't find anything relevant.

antonjw

I have also noticed some slow response in the post editor on my iPad 3. Sometimes I'll be trying to get the cursor to move and it wont be showing a cursor at all, as if it is not responding to touch. Then after a few seconds it will do as I prompt.

I have wondered whether that could be a CPU usage issue, too. Only thing is you don't get the fan noise or the Activity Monitor to confirm it on an iPad.

antonjw

Kulga I did a quick review and search for "cpu" but didn't find anything relevant.

Yes, me too (on here, anyway), hence creating this thread.

I'll submit a report, then. Cheers.

luceos

There's a performance tag. I'll make sure we dig into this once you publish an issue. I noticed some performance issues as well lately. I'm not sure, but it could be related to the non-delayed emoji popup.

JRay

I've noticed a lag in posting since the most recent update here. Everything was super fast before.

Franz

Was this ever reported?

@JoshyPHP Do you have some intuition on where this could come from?

JoshyPHP

I can't think of anything in my code that was changed in the last couple of months. My money's on emoji autocomplete so I'd try disabling the emoji extension and see if it's better. Then I'd try with all extensions disabled before testing each extension individually.

Toby

JoshyPHP Good thinking. Just tested locally. I was getting ~5% idle usage on Google Chrome, up to ~13% when the composer is open. After disabling all extensions and recompiling assets, nothing changed.

So it's something to do with core. My money is on Flarum's code being the problem, not TextFormatter's! ?

JoshyPHP

Toby For what it's worth, I'd look into that loop first. Try replacing it with a single regexp call that runs on value.substr(0, cursor) with a regexp like /(?:^|\s):[-+\w]+$/. To be efficient you could run it only on the last X characters of the text (where X is the max length of an emoji + 2) rather than everything from the start up to the cursor position. I'd also look into calling dropdown.hide() only if you know that the dropdown is open.

Franz

Hey, this would be a great opportunity to use browser profiling tools for the first time in my life. Sadly, I don't have the time right now. ?

Anybody up for the task?