What includedPosts for?

axdr

DiscussionPage.js

I suggest after line 165 next code is enough

    this.stream = new PostStream({discussion, []});
    this.stream.on('positionChanged', this.positionChanged.bind(this));
    this.stream.goToNumber(m.route.param('near') || 1, true);

We don't need to filter and map and sort etc.

Please explain if you know. Comment at line 165 is inconclusive.

luceos

axdr did you try your suggestion out? I fear there won't be any posts visible on the discussion page if you remove all that ? From what I've read, the includedPosts are a subset of the posts in a discussion. 20 are actually shown on first page hit and the actual focussed post is decided on by the near argument send to the api.

So tldr; creating a PostStream without a second argument will return an empty discussion.

axdr

luceos Of course I tried. Creating includedPosts is a waste of time.
At first I wanted to ask, why 20? There is variable PostStream.loadCount = 20.
Then I found out that it's no matter. Then I understood that includedPosts can be empty.