FriendsOfFlarum Night Mode

mekici

datitisev Thanks for the update. The appearance of the site is distorted when auto mode is on. No problem when one of the other modes is selected. there are no errors in the browser console.

datitisev

mekici Did you run the command to clear the cache? If so, try uninstalling nightmode & reinstalling it.

SecurityDog

@datitisev

mekici Have exactly the same problem, if "automatic" mode is selected, everything is destroid, like the picture of mekici.

Also reinstalled the extension, with no success.

Browser: Chrome

mekici

datitisev
Steps

I removed the extension
I cleared the cache.
I uploaded again.
I cleared the cache.

The result is the same.

datitisev

mekici What do you mean "uploaded"?

mekici

datitisev I reinstalled the extension (composer require fof/nightmode)

datitisev

mekici Hm. I'm assuming your browser does not support the prefers-color-scheme query.

0.5.1

Fix automatic mode looking wack in browsers that do not support the prefers-color-scheme (or something idk)

Updating

composer require fof/nightmode

L1fe

Love the night mode, and I decided it was going to be the first EXT I try to debug. That said. Since I installed it, and I wanted it more as an option than a default theme. It has become my default theme for any user that's not signed in. I do not want this to be the case, has this been already addressed?

[deleted]

L1fe Oh yeah... i reported this and i was hoping its in the latest update... crap 🙁

datitisev

L1fe [deleted] What guests see is the default option set in the admin settings. If it's set to automatic, it'll use the browser/system scheme. Changing that should change it for guests as well.

L1fe

datitisev That's not the case for me. imageofappearance

datitisev

L1fe Not in the appearance page, but in the extension settings. I assume you have my dashboard ext as the extensions page isn't shown, so go to Dashboard > FoF Night Mode, and click on the little settings icon.

datitisev

SecurityDog

If this happens to you, can you check if both files exist?

If you look at the source code of the page, you'll see two elements like this in <head>

<link rel="stylesheet" media="not (prefers-color-scheme: dark)" class="nightmode-light" href="<HOST>/assets/forum-ID.css">
<link rel="stylesheet" media="(prefers-color-scheme: dark)" class="nightmode-dark" href="<HOST>/assets/forum-dark-ID.css">

Or you can run the following in the JS console (still developer tools) to get the links to the CSS files.

$('.nightmode-light, .nightmode-dark').map((i, o) => o.getAttribute('href')).each(console.log)

SecurityDog

datitisev Both exists.

datitisev

SecurityDog Do you have a live URL where I could reproduce the issue? If you don't want to post it here, my discord is datitisev#7559.

datitisev

0.5.2

Fix issues with automatic mode & light theme in Chrome
- Reverted changes from 0.5.1
- Completely removed media query for light theme
  - not doesn't seem to be supported
  - the dark theme overrides light theme if prefers-color-scheme: dark matches

Updating

composer require fof/nightmode

Gatsu

datitisev Hi, thanks you for this update.
I think it doesn't work with a custom CSS theme.
I had change background's color and if I active night mode, I see only a widget (welcome statics widget) in black, not other.

wloot

code block looks buggy in dark mode.

datitisev

wloot This extension's "night mode" is just Flarum's dark mode now. Barely any CSS issues will be because of this extension. Any styles issues will be because of custom extension/forum CSS or Flarum's own CSS.

To add onto that, I cannot reproduce that issue locally.

danielunited

Hey, can you restore adding the 'dark' class to the body if the night mode is turned on? It makes additional CSS customization possible.

Kyrne

danielunited you can do custom LESS like this in place of .dark:

body {
 & when (@config-dark-mode = false) {
   // light mode
 }

 & when (@config-dark-mode = true) {
   // dark mode
 }
}

body when (@config-dark-mode = true) {
 // styles
 .CommentPost { ... }
}

iwoow

danielunited
Yes, yes, I hope so too.

« Previous Page Next Page »