Discussion and post author and date change

clarkwinkelmann

r4nchy is it a refresh issue (fixed with a full page reload)? Or a permanent difference that persists across reloads?

If it persists across reloads then it's probably the situation described in issue #4 above (as well as the README), you need to manually edit both the discussion (dropdown next to reply in the right sidebar) and the first post (3 dot menu under the first post)

If it's just a refresh issue, how are you experiencing it? Going back to homepage right after changing the author? In which order are you changing the post and discussion author?

r4nchy

clarkwinkelmann you need to manually edit both the discussion (dropdown next to reply in the right sidebar) and the first post (3 dot menu under the first post)

This worked, thanks

clarkwinkelmann

Version 1.0.0

Adds compatibility with Flarum 1.0
Adds "sync with first post" feature when editing discussion
Fix discussion last post meta not always updated

EDIT: post updated because I forgot to mention there were new features in addition to 1.0 compatibility!

Hari

clarkwinkelmann Thanks a lot

Hari

clarkwinkelmann user search is not working, unable to select any user . see this is happening in console

flarum 1.0 and Author Change 1.0.0

clarkwinkelmann

Hari I don't see the same errors as you but I noticed some problems when User Directory was enabled at the same time.

I have published version 1.0.1 with a fix.

If that doesn't fix it for you, can you share your php flarum info output?

Hari

clarkwinkelmann now I see no errors and its working perfectly

you did something something (magic) 😃

composer require clarkwinkelmann/flarum-ext-author-change

TB54

Hello,

When I change the date of a message (I want to use it when i split/merge conversation), they stay at the same place inside the discussion. I don't find a way to display the discussion in the (new) chronological order. Is it normal? Is it something I miss?

clarkwinkelmann

TB54 I think that in current Flarum version that's what should happen, yes.

However in the upcoming Flarum 1.3 version Flarum is moving away from date sorting and will now always sort by post number so the behavior you describe will be standard from 1.3 flarum/framework3282

You'd need another extension that re-numbers a discussion based on the new dates if you want to change the order "properly". Not sure how the Merge extension does it, maybe it could be an option over there to either order by number or by date before re-numbering the discussion.

Re-numbering in this extension could be problematic because it changes post permalinks. Re-numbering should only be done when moving posts to a new discussion.

TB54

clarkwinkelmann I think that in current Flarum version that's what should happen, yes.

Mmm, don't know what's not working then... Maybe an extension conflict?

But if I understand you well, even if I use date to change the place of a message, the message will comes back to it's original place (the one of its number) when the update will come? It will be retroactive?

clarkwinkelmann

TB54 the message will comes back to it's original place (the one of its number) when the update will come?

From what I understand from the Pull Request that was merged into Flarum, it will be retroactive yes, because it changes the column used for sorting in the SQL requests, so it will affect all existing discussions as well.

I wasn't aware of this change until now, I was reviewing the Flarum code on master branch to see how sorting is done and noticed it was changed from what I remembered. There's also an issue that outlines some of the reasons for the change flarum/framework3281

Unfortunately Flarum doesn't have any good way of re-ordering posts or adding posts in between existing ones. As the issue points out, not ordering by post number causes issues with perma-linking. But re-numbering posts would cause perma-links to change as well so there's really no good solution available at the moment 😬

Maybe perma-links should be decoupled from discussion pagination at some point. Post numbers in the URL could be kept to linking to a specific place in the discussion (nth-post), while a different perma-link would contain the post ID and redirect to the correct post number dynamically when accessed. It's less elegant, but would probably be the best option to add flexibility to the post stream without needing to change how the infinite scrolling and pagination works.

hrvoje_hr

After the Core update from 1.3.1 to 1.6.2 the user can't choose another author anymore. When another user is clicked in the modal window, it redirects to the user page

clarkwinkelmann

hrvoje_hr I cannot replicate the issue on Flarum 1.6.2 and extension 1.0.2 on Firefox. The related code in Flarum hasn't been modified since last year so it doesn't look like there was any change in Flarum that could break it.

Can you share your php flarum info output and browser information? It might be a conflict with another extension.

clarkwinkelmann

Version 1.0.3

Updated to Webpack 5. Requires Flarum 1.2+

hrvoje_hr

clarkwinkelmann is this related with my issue? Do you still need my php flarum info?

EDIT:

Flarum core 1.6.2 PHP version: 7.4.30 MySQL version: 5.5.5-10.4.20-MariaDB-1:10.4.20+maria~buster-log Loaded extensions: Core, date, libxml, openssl, pcre, zlib, filter, hash, pcntl, Reflection, SPL, session, standard, sodium, mysqlnd, PDO, xml, apcu, bcmath, bz2, calendar, ctype, curl, dba, dom, enchant, mbstring, FFI, fileinfo, ftp, gd, gettext, gmp, iconv, igbinary, imagick, imap, intl, json, exif, mongodb, msgpack, mysqli, odbc, pdo_dblib, PDO_Firebird, pdo_mysql, PDO_ODBC, pdo_pgsql, pdo_sqlite, pgsql, apc, posix, readline, redis, shmop, SimpleXML, soap, sockets, sqlite3, sysvmsg, sysvsem, sysvshm, tidy, tokenizer, xmlreader, xmlrpc, xmlwriter, xsl, zip, Phar, memcached, ionCube Loader, Zend OPcache +---------------------------------+---------+--------+ | Flarum Extensions | | | +---------------------------------+---------+--------+ | ID | Version | Commit | +---------------------------------+---------+--------+ | flarum-flags | v1.6.1 | | | flarum-approval | v1.6.1 | | | flarum-tags | v1.6.1 | | | flarum-suspend | v1.6.1 | | | askvortsov-auto-moderator | v0.1.2 | | | flarum-markdown | v1.6.1 | | | flarum-lock | v1.6.1 | | | flarum-subscriptions | v1.6.1 | | | fof-byobu | 1.1.7 | | | zerosonesfun-member | 1.2 | | | zerosonesfun-direct-links | 3.1 | | | v17development-user-badges | v1.1.0 | | | v17development-seo | v1.8.0 | | | therealsujitk-gifs | v4.1.1 | | | the-turk-flamoji | 1.0.4 | | | sycho-profile-cover | v1.3.3 | | | sycho-move-posts | v0.1.7 | | | noriods-auto-more | v1.0.0 | | | nearata-remove-pane | v2.0.1 | | | nearata-internal-links-noreload | v2.1.3 | | | nearata-cakeday | v2.1.0 | | | matteocontrini-imgur-upload | v3.9.1 | | | kilowhat-wordpress | 1.7.4 | | | ianm-syndication | 1.2.2 | | | fof-webhooks | 1.1.1 | | | fof-user-directory | 1.2.3 | | | fof-user-bio | 1.1.1 | | | fof-socialprofile | 1.1.4 | | | fof-sitemap | 1.0.3 | | | fof-reactions | 1.1.3 | | | fof-profile-image-crop | 1.1.0 | | | fof-pretty-mail | 1.1.1 | | | fof-polls | 1.3.0 | | | fof-pages | 1.0.4 | | | fof-nightmode | 1.5.1 | | | fof-merge-discussions | 1.3.1 | | | fof-masquerade | 2.1.3 | | | fof-links | 1.1.2 | | | fof-linguist | 1.0.4 | | | fof-ignore-users | 1.1.0 | | | fof-gamification | 1.6.2 | | | fof-formatting | 1.0.2 | | | fof-follow-tags | 1.1.7 | | | fof-drafts | 1.1.2 | | | fof-discussion-thumbnail | 1.1.0 | | | fof-bbcode-details | 1.1.0 | | | flarum-sticky | v1.6.1 | | | flarum-statistics | v1.6.1 | | | flarum-pusher | v1.6.1 | | | flarum-mentions | v1.6.1 | | | flarum-likes | v1.6.1 | | | flarum-lang-english | v1.6.0 | | | flarum-emoji | v1.6.1 | | | flarum-bbcode | v1.6.0 | | | ecnu-im-sticky-sidenav | v1.1.0 | | | davwheat-inline-group-badges | 1.0.0 | | | datlechin-silent-edit | v0.1.0 | | | datlechin-add-like-controls | v1.0.6 | | | datitisev-post-galleries | 1.0.0 | | | darkle-fancybox | 1.1.2 | | | clarkwinkelmann-roll-die | 1.0.0 | | | clarkwinkelmann-author-change | 1.0.3 | | | askvortsov-rich-text | v2.1.7 | | | askvortsov-pwa | v3.1.3 | | | askvortsov-moderator-warnings | v0.6.1 | | | afrux-forum-widgets-core | v0.1.7 | | | acpl-mobile-tab | 1.1.1

clarkwinkelmann

hrvoje_hr no, the update probably won't change anything, it's just general dependencies updates. But let me know if it does help!

I'll need a bit of time to go through that list. If you are able to test disabling some extensions to see if there's any difference it would help 🙂

andreagdipaolo

Hi, I would suggest allowing the user to pick the date and time in the client timezone.

Also it would be great to have a button "now" to quickly change the time to the current one.
That would be useful in combination with the approval extension for bumping posts and discussions that, if approved too late, would not appear in the forum homepage even though they are actually fresh and were just hidden.

navindra

This extension has served me very well in many ways. I've probably abused it too many times! 😃

Recently, I used it to hold a piano recital and I ran into a couple of issues.

The recital is here:
https://forum.pianotell.com/d/1044-pianotell-recital-1-is-now-live

There was a two week submission period during which participants submitted their performances. The submissions required approval and so were not generally visible.

The night before the recital went live, I updated all timestamps on all of the submissions to be in the future (Thursday, August 15, 2024 7:00 AM) so that I could approve/publish them all at once the next day and the posts wouldn't look stale. I was time crunched so I didn't test this a whole lot.

This caused two problems:

1) Users were unable to post, they got messages that they were posting too quickly and were blocked. I could disable throttling temporarily for the affected users. I assume this only impacted participants and the throttling algorithm got confused by the posts that were dated in the future. Is that right?

2) The indexing broke for the second half of the performances. For example this link:
https://forum.pianotell.com/d/1044-pianotell-recital-1-is-now-live/28
would instead reload to:
https://forum.pianotell.com/d/1044-pianotell-recital-1-is-now-live

Links from @replies were broken as well.

So I went and updated the timestamp on the posts that were broken from:
Thursday, August 15, 2024 7:00 AM
to:
Thursday, August 15, 2024 7:01 AM
and that fixed it.

I assume that something with all those posts having the same time caused the glitch.

Actually I don't really understand what caused problem no 2 or why updating the time fixed it, can anyone explain it?

Is there some way of avoiding these issues in the future? What other problems might I be causing when updating timestamps like this?

Thank you!

clarkwinkelmann

navindra your first issue is with Flarum's throttling features. It check if the time since the last user post is greater than a given number of seconds. If there exists a post with a date in the future, the test will always fail as the time difference will be negative.

For your second issue, I don't really know what to suggest. This extension isn't designed to re-order posts. The posts are not re-numbered, and having dates and numbers not align can cause all sort of undefined behavior with Flarum.

navindra

clarkwinkelmann If there exists a post with a date in the future, the test will always fail as the time difference will be negative.

Thanks, so then if I find the right spot, I could patch the code to ignore negative time differences or posts that are in the future.

clarkwinkelmann For your second issue, I don't really know what to suggest. This extension isn't designed to re-order posts. The posts are not re-numbered, and having dates and numbers not align can cause all sort of undefined behavior with Flarum.

What caused the re-order operation? Is it because I assigned the same time to sequential posts?

Would it be possible to have the extension automatically increment the number of micro or nano seconds for sequential posts that are assigned the same time? Or is Flarum limited to only minutes?

« Previous Page