Serbian language pack

bugsysha

Hello guys. First of all I would like to say thank you for creating this great piece of software and leaving it free. I love it. For over a year I'm waiting impatiently for stable release and I would like to help as much as possible if I can.

I'm trying to create language pack for my country but I've run into a bunch of problems.
First problem I've run into is that I can't update to beta 4.

composer update

Command above didn't do anything.

Next issue is that I can't create extension that works. I can see it in extensions admin panel, I can activate it, but it doesn't change any of text on the Flarum. I've used many extensions as examples but they didn't work. For example I've tried making it out of flarum/flarum-ext-english, maelsoucaze/flarum-ext-french, rodymol123/Flarum-nl-NL, flame05/flarum-ita, FlarumES/Spanish, cbrspc/FLARUM-LP-RUS, and many others. Probably I'm missing something but I can't figure out what.

Also when I add new language pack it doesn't show up in admin basics page. I need to change it manually in the database, but then for that language it doesn't show the name of the language, but only "Default" string. Now when I remove that extension that I've created in admin panel everything is showing up as core.admin.basics.forum_title_heading and not Forum Title.

I think that is about it. Later I would try to create extension that will disable email registration and only leave SSO.

Any help would be great.

Thanks in advance,
Bugsysha

Qiaeru

bugsysha Hey! Can you please add a link to your language pack to see what's the issue? You can upload it to GitHub for example, it will be easier to submit fixes.

bugsysha

Qiaeru https://github.com/laravelrs/Flarum-sr-RS
Thanks in advance ?

Qiaeru

Thanks! I'll look into it when I'll have free time, and submit some pull requests (I saw some little things to fix). Do you want a language pack compatible with the current beta release (Flarum 1.0.0 Beta 3) or the coming beta release (Flarum 1.0.0 Beta 4)?

luceos

Qiaeru current beta release (Flarum 1.0.0 Beta 3) or the coming beta release (Flarum 1.0.0 Beta 4)

Beta 4 is incorrectly shown in admin as beta 3. The upcoming release in fact is beta 5. You can verify this based on the github milestones: https://github.com/flarum/core/milestones

It would be amazing if you'd patch this lang pack to work @Qiaeru!

bugsysha

Qiaeru I want it to be compatible with my current version beta 3, cause I wrote up that for some reason I can not update it to beta 4, but I also want it to be compatible with beta 4 and next releases. Is that possible? If not than I need it for current, beta 3, and when I'm able to update I will update the package.

luceos So you are saying that I might have beta 4 installed? How can I verify which one do I have? Thanks.

Qiaeru

Yeah, my bad, I was talking about Beta 4 and Beta 5! ?

jordanjay29

bugsysha run composer update flarum/core

If nothing happens, you're on Beta 4.

bugsysha

jordanjay29

Nothing to install or update

I guess then I'm on Beta 4. Ok then I need it to work with Beta 4 and next releases ?

Qiaeru

Okay, I created a pull request with all the changes: https://github.com/laravelrs/Flarum-sr-RS/pull/1

Important: You'll have to rename your GitHub repository to flarum-ext-serbian-latin.

Then, after that merging and renaming, you should submit it on Packagist. Before that, it will be nice to fully translate the English and Norvegian references into Serbian (Latin Script), because it will be weird to use.

Note that I sent you a Flarum 1.0.0 Beta 4 compatible language pack. The next beta release will be available soon, so you'll have to update it with the most recent changes.

You can see all my changes here: https://github.com/laravelrs/Flarum-sr-RS/pull/1/files

bugsysha

Thank you so much. Did all you advised. Still haven't tried it but I guess there should be no issues.

New URL is https://github.com/laravelrs/flarum-ext-serbian-latin

Now I will translate what's left and v1.0.3 should be good for public use. Also when I finish that I'll create cyrillic package.

Thanks once again, I'll update here when I finish.

Qiaeru

You're welcome! ?

Everything should work without any issues, and the structure is now compatible with the latest language pack guidelines for Flarum.

If you're not used to update frequently your language pack with the development version, you should wait the next beta release. It will be possible to view the diffs and it will be easier to update.

If you have any further questions, be my guest, I'll try to help when it's possible. I'm not a developer, but I'm used to work on software localization, so I'm glad to help for it.

bugsysha

Now when I activate extension text doesn't change.

When I activate extension on admin#/basics page, the default language select box doesn't show up but it didn't show up before also. I needed to change default_locale in the settings table in the database. Since in the composer.json file flarum-locale code is set to sr-Latn (guess this is a typo that I didn't change/notice) that is what I've entered in the table column. Is that the correct way to change language for now?

Inside assets folder few *.js files are generated. Some of them contain same strings that has English language pack. One of those files is assets/forum-sr-Latn-df77f08d.js, but as I said, it contains only english translation strings, and I guess it should contain Serbian language strings. When I delete those files they are regenerated but again they contain English language strings.

Any advice? Thanks.

Qiaeru

There is no typos on the language code, it's the official one defined in BCP 47.

However, this should fix your issue for all. ?

bugsysha

Thanks. I'll try it when I get home back from work. ?

Regarding typo, I'm ashamed ?
You know more about my language than me ?

bugsysha

Nope. Didn't help. Still same issues. Also discussions sort select box now only shows arrows, text is missing for some reason only for the "Latest" option.

Any ideas? Thanks.

Franz

bugsysha Also discussions sort select box now only shows arrows, text is missing for some reason only for the "Latest" option.

That may actually be caused by a small bug that is fixed in latest dev-master.

Qiaeru

bugsysha I tested your extension on Flarum 0.1.0 Beta 4 and eveything's working fine, I see the text translated when I select your language. Other issues are not related to the language pack itself.

bugsysha

Franz Ok, that's great. Thanks. I'll wait for that.

Qiaeru Can you please write here all the steps from adding the package to activating it. Since I can not have more than one language.