Forum crash - 404 error, looking for js-files pushed by git from local repo

chesterlaykin

My forum crashed, I can see in network tab 404 errors for three ".js" bundle files. These files exist on my local repo.

I tried deleting the ".js", ".css" and".map" files so new ones could be regenerated. But it still asks for those local files. I had some permissions issues, so when I pushed it wouldn't create new files in the assets folder on the remote server. But it was still working then, and when I changed permissions to 777 on the 'public' folders and pushed, then the forum crashed.

Should the assets bundle files be gitignored? And the second question, how can I fix this - should I upload the local js-files or can I delete some file that's calling for the bundled files?

chesterlaykin

Okay, I got it fixed - I just needed to delete the "rev-manifest.json" file (that's the file who is calling the bundle files I guess).

But I need to gitignore those files?

clarkwinkelmann

chesterlaykin But I need to gitignore those files?

I think it's best to ignore them yes. They will be re-generated each time Flarum cache is cleared, and this can be triggered by actions other than installing/updating extensions, so it probably doesn't make sense to version them.

Javascript dist files that are part of an extension MUST be commited however.

chesterlaykin

Okay thanks. The problem didn't go away though, it's extremely strange. I have gitignored the public folder, and if I change one letter in a text file and push it, then it seems the rev-manifest.json is regenerated and include references to my local files(?!). So it crashes each time I push. I'm not sure how this works..

clarkwinkelmann

chesterlaykin rev-manifest.json and any file referenced inside of it should also be omitted from the version control.

If you are forking Flarum, it might be best to put individual composer packages under version control instead of the whole app.

chesterlaykin

Yes rev-manifest.json is gitignored (everything in 'public' folder). That's why I can't figure out how it happens.
I can only try to remove parts from the version control until the problem goes away.

clarkwinkelmann

chesterlaykin you can maybe just run php flarum cache:clear every time you deploy your code ?

chesterlaykin

I get an error when running php flarum cache:clear:InvalidArgumentException: Unsupported driver [] (in ConnectionFactory).

Do you know what that's about..or should I make a separate post about it?

luceos

chesterlaykin did you install Flarum already? Does a config.php exist?

chesterlaykin

Yes, I use "Dotenv" package, so in config.php I have:

'database' => 
    array (
      'driver'      => getenv('DATABASE_DRIVER') ?? 'mysql',

And in the ENV file:

  `DATABASE_DRIVER=mysql`

And the forum and database is working , so that error seems strange.

luceos

Where did you call Dotenv to load the directory containing the .env file? Please also post that.

chesterlaykin

I require it in index.php, here is the whole file:

<?php

/*
 * This file is part of Flarum.
 *
 * (c) Toby Zerner <toby.zerner@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
 
require '../vendor/autoload.php';

$dotenv = Dotenv\Dotenv::create( __DIR__ . '/../');
$dotenv->load();

$server = new Flarum\Http\Server(
    Flarum\Foundation\Site::fromPaths([
        'base' => __DIR__.'/..',
        'public' => __DIR__.'/../public',
        'storage' => __DIR__.'/../storage',
    ])
);

$server->listen();

I can try removing, just to see if that's the problem..

chesterlaykin

Okay it worked when I removed the dotenv stuff.
So there's some compatibility problem there I guess..

I like Dotenv though, because it makes it easy to have different configuration on local environment and production.

luceos

This is my dotenv setup:

my .env file lives in the flarum root directory
i have different config files stored under config/ similar to what laravel usually does
my config.php loads each config file and assigns it to the return array

Here it goes:

<?php

use Dotenv\Dotenv;

(new Dotenv(__DIR__))->load();

$app      = include __DIR__ . '/config/app.php';
$database = include __DIR__ . '/config/database.php';

return [
    'app'      => $app,
    'database' => $database,
    'url'      => array_get($app, 'url'),
    'debug'    => array_get($app, 'debug', false),
];

config/app.php

<?php

return [
    'env' => env('APP_ENV', 'production'),
    'url' => env('APP_URL', 'https://bokt.nl'),
    'debug' => env('APP_DEBUG', false),
];

config/database.php

<?php

return [
    'driver' => 'mysql',
    'host' => env('DB_HOST', '127.0.0.1'),
    'port' => env('DB_PORT', '3306'),
    'database' => env('DB_DATABASE', 'bokt_flarum'),
    'username' => env('DB_USERNAME', 'root'),
    'password' => env('DB_PASSWORD', ''),
    'unix_socket' => env('DB_SOCKET', ''),
    'charset' => 'utf8mb4',
    'collation' => 'utf8mb4_unicode_ci',
    'prefix' => env('DB_PREFIX', ''),
    'strict' => true,
    'engine' => null,
    'options' => [
        PDO::ATTR_PERSISTENT => true,
    ]
];

I have more configuration files (queue and session), that's also a reason I separated them.

The drawback of this method is that it will not work if your forum isn't installed yet. Your database has to exist and has to be installed.

chesterlaykin

My .envis also in the root directory (outside public).
So your file beginning with "use Dotenv\Dotenv;" also lies in root directory I guess?
But how is it required from index.php ? Maybe that's the key part.

luceos

chesterlaykin Flarum reads the config.php during runtime. Flarum uses it to identify whether the forum is already installed or not. The config.php is stored in the installation (root) directory of Flarum.

chesterlaykin

luceos edit: Aha now I understand a little better. To make a long story short, it seems you are initializing Dotenv in config.php, whereas Im doing it in index.php, which may be too early? I could try changing that.