Style the login modal

gigamick

Hi, I'd like to add some text to the login modal, along the lines of "by creating an account you're agreeing to our terms and conditions" - with a link to ts and cs.

I can't find the view for the login / signup modal. Any ideas?

Thanks.

datitisev

gigamick The modals are, I think, added via JS and removed when exited out of them.
You would have to change the JavaScript file, and then compile it running a command that I can't remember right now.

jordanjay29

datitisev You could do that, but it wouldn't persist between updates. A better way to do it is to create an extension, which includes some of the same process you're talking about (gulp is the compilation method you were looking for) but allows it to be enabled/disabled and persist between updates.

It shouldn't be terribly hard to do, gigamick, either you or someone could write an extension for it.

Dominion

gigamick As jordanjay29 said, the best approach would be to create an extension; modifying the core directly isn't recommended because any changes will be wiped out by new versions of the software. (That's why I suggested using the logo upload extension as well.)

The file you're looking for is js/forum/src/components/LoginModal.js ... if you'd like to create an extension that modifies that, I'd suggest looking at Toby's Quick Start tutorial for the basics.

There's also a possibility Flarum will have a welcome banner feature that you might be able to adapt for your purposes ... but that's still a ways down the road.

gigamick I think there must be a view somewhere as the text that is being output into the modal doesn't exist in that JS files anywhere. Looked signupmodal.js and loginmodal.js.

Language resources are all extracted to separate files for easy localization. You'd have to do the same thing for your extension ... you can read about how that's done here.

gigamick incase you're interested - all set up in the past couple hours:

Nice color scheme!

gigamick

datitisev I think there must be a view somewhere as the text that is being output into the modal doesn't exist in that JS files anywhere. Looked signupmodal.js and loginmodal.js.

gigamick

Ok, interesting. I'll see what I can do.

Thanks :-)

incase you're interested - all set up in the past couple hours:

http://lyrical.me/flarum

Franz

gigamick Totally love the color scheme, too. Very easy on the eyes! ?

gigamick

Ok Dominion thanks very much. I'll have a look at getting into this tomorrow. Seems like an excellent way to force myself to get to grips with symfony. Excited by Flarum! Been looking at MUUT and Discourse, but they both suck.

gigamick

Dominion Thank you :-)

Dominion

gigamick Good luck! I'm guessing all you'd have to do is extend that modal and add your text. (I'm not a programmer by any stretch of the imagination, though, so don't quote me on that. ? )

Extracting strings for translation isn't really required unless you want to make your extension available for use by others; so if you feel it's too much bother, you can skip that part.

If you have any questions, feel free to ask here or in Gitter!

datitisev

gigamick Am I supposed to be able to see the discussions without signing up?
When I load the page, it shows me the discussions.
When I click the button to refresh the list of discussions, it says there are no discussions.
When I click on a discussion, it says Resource not found.
This is the debug:

404 Not Found

GET http://lyrical.me/flarum/api/discussions/5?page%5Bnear%5D=0

<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>404 Not Found</title>
</head><body>
<h1>Not Found</h1>
<p>The requested URL /flarum/api/discussions/5 was not found on this server.</p>
<hr>
<address>Apache/2.4.7 (Ubuntu) Server at lyrical.me Port 80</address>
</body></html>

Something must be wrong with your .htaccess or something... Weird.

gigamick

datitisev That's weird I just came onto the forum this morning to report that very issue!

How odd. I'm guessing this is unusual behaviour even for the beta?

gigamick

It seems that on hard refresh (CMD + R) the discussions load fine. When you use the internal refresh they disappear.

datitisev

gigamick Can you post your .htaccess?

gigamick

# Allow access if Flarum is installed in a subdirectory,
# but another .htaccess in a higher directory denies access.

<IfModule mod_authz_core.c>
  Require all granted
</IfModule>
<IfModule !mod_authz_core.c>
  Order Allow,Deny
  Allow from all
</IfModule>

<IfModule mod_rewrite.c>
  RewriteEngine on


  RewriteRule .* - [E=HTTP_AUTHORIZATION:%{HTTP:Authorization}]

  RewriteRule ^vendor/(.*)?$ / [F,L]
  RewriteRule ^storage/(.*)?$ / [F,L]
  RewriteRule ^config.php$ / [F,L]

  RewriteRule ^api(.*)$ api.php [QSA,L]
  RewriteRule ^admin(.*)$ admin.php [QSA,L]

  RewriteCond %{REQUEST_FILENAME} !-f
  RewriteCond %{REQUEST_FILENAME} !-d
  RewriteRule !^assets index.php [QSA,L]

  # MultiViews can mess up our rewriting scheme
  Options -MultiViews

  # Autoindex will list all assets files which is not so good
  Options -Indexes
  


  

</IfModule>

<IfModule mod_deflate.c>
  # Compress all output labeled with one of the following MIME-types
  <IfModule mod_filter.c>
    AddOutputFilterByType DEFLATE application/atom+xml \
                                  application/javascript \
                                  application/json \
                                  application/vnd.ms-fontobject \
                                  application/x-font-ttf \
                                  application/x-web-app-manifest+json \
                                  application/xhtml+xml \
                                  application/xml \
                                  font/opentype \
                                  image/svg+xml \
                                  image/x-icon \
                                  text/css \
                                  text/html \
                                  text/plain \
                                  text/xml
  </IfModule>
</IfModule>

# Configure cache expiry for different file types
<IfModule mod_expires.c>
  ExpiresActive on
  ExpiresDefault                                      "access plus 1 second"

  ExpiresByType text/css                              "access plus 1 year"
  ExpiresByType application/json                      "access plus 0 seconds"
  ExpiresByType application/xml                       "access plus 0 seconds"
  ExpiresByType text/xml                              "access plus 0 seconds"
  ExpiresByType image/x-icon                          "access plus 1 week"
  ExpiresByType text/html                             "access plus 0 seconds"
  ExpiresByType application/javascript                "access plus 1 year"
  ExpiresByType application/x-web-app-manifest+json   "access plus 0 seconds"
  ExpiresByType text/cache-manifest                   "access plus 0 seconds"
  ExpiresByType image/gif                             "access plus 1 month"
  ExpiresByType image/jpeg                            "access plus 1 month"
  ExpiresByType image/png                             "access plus 1 month"
  ExpiresByType application/atom+xml                  "access plus 1 hour"
  ExpiresByType application/rss+xml                   "access plus 1 hour"
  ExpiresByType application/font-woff2                "access plus 1 month"
  ExpiresByType application/font-woff                 "access plus 1 month"
  ExpiresByType application/vnd.ms-fontobject         "access plus 1 month"
  ExpiresByType application/x-font-ttf                "access plus 1 month"
  ExpiresByType font/opentype                         "access plus 1 month"
  ExpiresByType image/svg+xml                         "access plus 1 month"
</IfModule>

datitisev

gigamick Can you add your config.php also, please?

gigamick

<?php return array (
  'debug' => true,
  'database' => 
  array (
    'driver' => 'mysql',
    'host' => 'localhost',
    'database' => 'REMOVED',
    'username' => 'REMOVED',
    'password' => 'REMOVED',
    'charset' => 'utf8mb4',
    'collation' => 'utf8mb4_unicode_ci',
    'prefix' => 'flares',
    'strict' => false,
  ),
  'url' => 'http://lyrical.me/flarum',
  'paths' => 
  array (
    'api' => 'api',
    'admin' => 'admin',
  ),
);

ps - thank you

Franz

gigamick Never, ever post your credentials on a forum. I removed the password from the above post, but you may want to change it anyway.

datitisev

gigamick Well, sorry, I don't know anything else ?
Hopefully someone else like Kulga can help you figure it out

gigamick

Christ! I know better than that!!

Thank you Franz!

In a rush!

gigamick

So the config and htaccess look ok? datitisev