Title doesn't change

tolgaaaltas

I don't know why this is happening but when i visit discussion, profile or page (fof/pages) and go back to home title doesn't changing.

If i visited "x" users, title still same "x" value.

php flarum info output:

Flarum core 0.1.0-beta.12
PHP version: 7.2.24-0ubuntu0.18.04.3
Loaded extensions: Core, date, libxml, openssl, pcre, zlib, filter, hash, pcntl, Reflection, SPL, sodium, session, standard, mysqlnd, PDO, xml, bcmath, bz2, calendar, ctype, curl, dom, mbstring, fileinfo, ftp, gd, gettext, iconv, intl, json, exif, mysqli, pdo_mysql, Phar, posix, pspell, readline, shmop, SimpleXML, sockets, sysvmsg, sysvsem, sysvshm, tokenizer, wddx, xmlreader, xmlwriter, xsl, zip, Zend OPcache
+---------------------------------+----------------+--------+
| Flarum Extensions               |                |        |
+---------------------------------+----------------+--------+
| ID                              | Version        | Commit |
+---------------------------------+----------------+--------+
| flarum-tags                     | v0.1.0-beta.12 |        |
| flarum-pusher                   | v0.1.0-beta.12 |        |
| flarum-bbcode                   | v0.1.0-beta.12 |        |
| flarum-emoji                    | v0.1.0-beta.12 |        |
| flarum-likes                    | v0.1.0-beta.12 |        |
| flarum-suspend                  | v0.1.0-beta.12 |        |
| flarum-lock                     | v0.1.0-beta.12 |        |
| flarum-subscriptions            | v0.1.0-beta.12 |        |
| flarum-sticky                   | v0.1.0-beta.12 |        |
| flarum-statistics               | v0.1.0-beta.12 |        |
| flarum-markdown                 | v0.1.0-beta.12 |        |
| flarum-mentions                 | v0.1.0-beta.12 |        |
| flarum-flags                    | v0.1.0-beta.12 |        |
| flagrow-analytics               | 0.8.0          |        |
| noriods-auto-more               | 0.3.0          |        |
| michaelbelgium-discussion-views | v3.1.0         |        |
| squeevee-fancybox               | 0.2-beta       |        |
| xelson-chat                     | 0.7.3          |        |
| franzl-open-links-in-new-tab    | v0.1.0         |        |
| clarkwinkelmann-passwordless    | 1.0.3          |        |
| tolgaaaltas-turkish             | 0.1.58         |        |
| tolgaaaltas-lang-turkish        | 0.12           |        |
| nikovonlas-web-push             | v0.1.0-beta.9  |        |
| clarkwinkelmann-who-read        | 1.0.0-beta1    |        |
| amaurycarrade-syndication       | v0.3.1         |        |
| jordanjay29-summaries           | 0.3.1          |        |
| flagrow-sitemap                 | 0.2.0          |        |
| fof-disposable-emails           | 0.1.0          |        |
| v17development-seo              | 1.1            |        |
| fof-formatting                  | 0.1.4          |        |
| fof-follow-tags                 | 0.3.4          |        |
| fof-nightmode                   | 0.4.0          |        |
| fof-links                       | 0.2.1          |        |
| fof-merge-discussions           | 0.3.3          |        |
| fof-pages                       | 0.3.0          |        |
| fof-polls                       | 0.1.1          |        |
| reflar-cookie-consent           | 0.2.0          |        |
| fof-transliterator              | 0.2.0          |        |
| fof-upload                      | 0.8.2          |        |
| fof-user-directory              | 0.3.3          |        |
| fof-byobu                       | 0.4.3          |        |
| fof-forum-statistics-widget     | 0.1.1          |        |
+---------------------------------+----------------+--------+
Base URL: https://zincirsiz.net
Installation path: /home/zincirsiz/web/zincirsiz.net/public_html
Debug mode: ON

I saw this issue on giffgaff, FlarumTR and many other Flarum based site.

Browser:

The New Microsoft Edge (Chromium-based) 80.0.361.66 (Windows)
Microsoft Edge 45.01.24.4900 (Android)
Microsoft Edge 44.13.3 (iOS)

tolgaaaltas

@Littlegolden did you find a solution?

Littlegolden

tolgaaaltas I don't know.... One flarum form doesn't have this problem... but another one does have... I think it's some extension's fault....

The diff of enabled extension list between this two Flarum forum：
https://www.diffchecker.com/1wkKnvNm

tolgaaaltas

Littlegolden i'm not sure, FlarumTR doesn't have the diff extension installed.

Kylo

tolgaaaltas i think (s)he meant the diff on diffchecker, not the extension. Diff extension can't be causing this issue.

tolgaaaltas

Kylo oh got it.

Littlegolden

Kylo Just changed the sentence... I think this time... 😅 (My fault)

tolgaaaltas

Littlegolden I found what broke the title: xelson/flarum-ext-chat

@Xelson can you check this issue?

clarkwinkelmann

tolgaaaltas can you try disabling as many extensions as possible and share the smaller php flarum info you can reproduce the issue with ?

I have been doing some investigation but have not pinpointed the issue yet.

It seems like something happens to the config method of IndexPage so that it no longer runs on page change.

The only extension that manipulates a config method and is present on all forums is Nightmode. But I installed nightmode and couldn't reproduce.

The Realtime Chat extension is present on two of the forums. I also installed it but can't reproduce the issue. Maybe it's only reproductible when I fill in all settings ? Looking at the source code I can't see where it could go wrong either. Realtime Chat is not manipulating the config method of any page.

Giffgaff doesn't have Realtime Chat, but they have plenty of customization of their own. Maybe the issue there is not linked to a publicly available extension.

tolgaaaltas

clarkwinkelmann sure, i disabled all FoF extensions but the issue is still exists:

Flarum core 0.1.0-beta.12
PHP version: 7.2.24-0ubuntu0.18.04.3
Loaded extensions: Core, date, libxml, openssl, pcre, zlib, filter, hash, pcntl, Reflection, SPL, sodium, session, standard, mysqlnd, PDO, xml, bcmath, bz2, calendar, ctype, curl, dom, mbstring, fileinfo, ftp, gd, gettext, iconv, intl, json, exif, mysqli, pdo_mysql, Phar, posix, pspell, readline, shmop, SimpleXML, sockets, sysvmsg, sysvsem, sysvshm, tokenizer, wddx, xmlreader, xmlwriter, xsl, zip, Zend OPcache
+---------------------------------+----------------+--------+
| Flarum Extensions               |                |        |
+---------------------------------+----------------+--------+
| ID                              | Version        | Commit |
+---------------------------------+----------------+--------+
| flarum-tags                     | v0.1.0-beta.12 |        |
| flarum-pusher                   | v0.1.0-beta.12 |        |
| flarum-bbcode                   | v0.1.0-beta.12 |        |
| flarum-emoji                    | v0.1.0-beta.12 |        |
| flarum-likes                    | v0.1.0-beta.12 |        |
| flarum-suspend                  | v0.1.0-beta.12 |        |
| flarum-lock                     | v0.1.0-beta.12 |        |
| flarum-subscriptions            | v0.1.0-beta.12 |        |
| flarum-sticky                   | v0.1.0-beta.12 |        |
| flarum-statistics               | v0.1.0-beta.12 |        |
| flarum-mentions                 | v0.1.0-beta.12 |        |
| flarum-flags                    | v0.1.0-beta.12 |        |
| tolgaaaltas-turkish             | 0.1.59         |        |
| tolgaaaltas-lang-turkish        | 0.12           |        |
| flarum-markdown                 | v0.1.0-beta.12 |        |
| flagrow-analytics               | 0.8.0          |        |
| noriods-auto-more               | 0.3.0          |        |
| the-turk-diff                   | 0.1.0-beta.7   |        |
| michaelbelgium-discussion-views | v3.1.0         |        |
| squeevee-fancybox               | 0.2-beta       |        |
| flagrow-sitemap                 | 0.2.0          |        |
| xelson-chat                     | 0.7.3          |        |
| franzl-open-links-in-new-tab    | v0.1.0         |        |
| clarkwinkelmann-passwordless    | 1.0.3          |        |
| the-turk-quiet-edits            | 0.1.1          |        |
| reflar-cookie-consent           | 0.2.0          |        |
| v17development-seo              | 1.1            |        |
| jordanjay29-summaries           | 0.3.1          |        |
| amaurycarrade-syndication       | v0.3.1         |        |
| nikovonlas-web-push             | v0.1.0-beta.9  |        |
| clarkwinkelmann-who-read        | 1.0.0-beta2    |        |
+---------------------------------+----------------+--------+
Base URL: https://zincirsiz.net
Installation path: /home/zincirsiz/web/zincirsiz.net/public_html
Debug mode: ON

Plus;

I disabled every single third party extension (except xelson/flarum-ext-chat) but... the issue is still exists.

Xelson

tolgaaaltas clarkwinkelmann Found out very quickly:

import {extend} from 'flarum/extend';
import HeaderPrimary from 'flarum/components/HeaderPrimary';
import ChatFrame from './components/ChatFrame';

app.initializers.add('pushedx-chat', app =>
{
    extend(HeaderPrimary.prototype, 'items', function(items) 
    {
        m.redraw.strategy('diff');
        items.add('pushedx-chat-frame', <ChatFrame />);
    });
});

Line m.redraw.strategy('diff'); does not allow to change the title. I did this because the chat is redrawn from scratch when route changes. But if the chat is redrawn the media content stops and listening to music or watching videos while surfing the forum is not possible. I've been looking for a solution to this problem for quite a long time and haven't found anything other than this. clarkwinkelmann what do you think of that?