Have extended permissions with the Tags extension

nether494

Hi,

Is it possible to have an update of the extension Tags (https://github.com/flarum/tags) which allows to attribute to a few group of people a non respect of the restrictions of tags?

For example I defined a primary and secondary tags limit but it applies to administrators and members... I would only like this limit to be for members and not for administrators

I can't find this option even in permissions menu

What do you think about this feature???

Thanks,
Best regards

clarkwinkelmann

nether494 that would make sense.

Personally I was a bit surprised that we didn't already let administrators bypass those requirements by default.

On some forums you might actually not want to let administrator break the rules, if it can lead to integrity issues with what you expect on your forum. And the problem of using a permission is that an administrator always has all permissions. You can't deny an admin anymore.

If someone wants to submit a PR for it, you are welcome.

nether494

clarkwinkelmann It is true that administrators can abuse, but it is also a risk to be taken. In the logic of things we should not restrict an administrator because he has all the rights

Pollux

nether494 In the logic of things we should not restrict an administrator because he has all the rights

I support your proposal.

I have a discussion in my forum that does not belong to any tag, although this is not allowed. I (as admin) simply relaxed the rule, posted my discussion and changed the rule back to how it was before. This is not very convenient, but it doesn't create any more problems and is a solution for occasional cases.

askvortsov

One benefit to allowing extendability of the tag count requirements is that it leads to other useful applications; for instance, perhaps Byobu could allow private discussions to have no tags?

clarkwinkelmann

askvortsov I see a few solutions:

Just add an ->isAdmin() check in there to skip the count check logic. Very easy change, only affects admins. Not an extensible solution, but still useful.
Add dedicated permission "skip tag restrictions". If we scope it with discussion. prefix, it could even be customized per-tag.

Allowing to scope it per-tag could allow advanced customization but I fear it would also lead to even more issues with the way tag permissions work. If you applied any unrestricted tag, it would lift all restrictions.

I'm not sure how this same fix could be used to allow no tags for some discussions askvortsov . For that specific use case I think it would be best for the Tags extension to expose an event or something so that extensions can conditionally enable or disable the check.

If someone could maybe create a GitHub issue to summarize this discussion so we don't forget about it, that would be great.

nether494

Hi,

Anyone new? Did you find a solution? 😁

Best regards

clarkwinkelmann

nether494 we need:

A GitHub issue
Discuss possible implementations
Implement the chosen choice

I see multiple solutions here. But this needs some discussions to decide which one we want to go with.

nether494

clarkwinkelmann Yes but impossible for me to open a issue... The issue function on GitHub is unavailable for your project

askvortsov

nether494 We manage issues for bundled extensions through the core issue tracker, this makes it easier for our core devs to keep everything in one place. An issue can be openned here: https://github.com/flarum/core/issues.