Avatar upload still doesnt work in beta 5 (Windows)

Highstrike

Averell According to the examples in http://image.intervention.io/api/make, in the "make" method you shouldn't put files that end up as temporary files.

I just did a var_dump of $tmpFile and it was something like "project/storage/tmp/ava9E18.tmp" which is wrong.

jordanjay29

Highstrike This is where the Exception happens

Exception lines can be deceiving, sometimes the error actually occurs elsewhere, but that's just where it's called in runtime.

Highstrike

jordanjay29 True, but that is the line that invokes the Intervention Image 3rd party library

EDIT
Alright, I think on linux when you upload a file it doesn't change extension because the code on line 99 takes that file, shrinks it into 100x100 and then saves it once again.

Problem is, on windows the uploaded file has it's extension changed from .jpg or .png or whatever into .tmp and the Exception is happening on that line because the program tries to shrink an invalid picture according to it because its of .tmp extension.

Averell

Highstrike This fix works :

$tmpFile = tempnam($this->app->storagePath().'/tmp', 'avatar');
$tmpFile = $tmpFile . ".jpg";

Add the line $tmpFile = $tmpFile . ".jpg"; after line 84.
Enjoy !
And it works also for gif and png files !

(Still a dirty workaround, clearly, but it shows where the problem is).

Highstrike

Averell Cool, that works

So the uploaded file will actually be "project\storage\tmp\ava08b.tmp.jpg"
But hey, it works ?

I've changed line 84 into this

$tmpFile = tempnam($this->app->storagePath().'/tmp', 'avatar') . '.jpg';

Thanks!

PS: It's a sloppy fix though so this issue is still not solved.

Doc

Averell It works!!!!!!!!!!

Averell

Highstrike It's a sloppy fix though so this issue is still not solved.

And also the temp file is not deleted, just set to 0 bytes

flarumr

Highstrike I've got a similar issue. I tried your fix without success. When I try to upload a avatar picture then the avatar is always grey.

I am using beta 5 with php 5.5 on ubuntu webserver.

Averell

slightly better to avoid the double extension :

$tmpFile = tempnam($this->app->storagePath().'/tmp', 'avatar');
$tmpFile = str_replace(".tmp", ".jpg", $tmpFile);

Filename is now (for example) : "project\storage\tmp\ava08b.jpg"
But the tempfile (ava08b.tmp) is not deleted.

Averell

And now the temp file is deleted :

$tmpFile1 = tempnam($this->app->storagePath().'/tmp', 'avatar');
$tmpFile = str_replace(".tmp", ".jpg", $tmpFile1);
register_shutdown_function(create_function('', "unlink('{$tmpFile1}');"));
$command->file->moveTo($tmpFile);

Highstrike

I feel this is like putting ductape on a broken airplane wing of some sort... It might work but it doesn't linspire any confidence to get on it hahahahha

Averell

Want it simple ?

$tmpFile = $this->app->storagePath().'/tmp/avatar' . rand() . '.jpg';
$command->file->moveTo($tmpFile);

Kulga

flarumr I am using beta 5 with php 5.5 on ubuntu webserver.

This thread is focused on a fix for windows server
Please open a new thread for your issue.

KazeFlame

I have created a pull request to fix this issue.
https://github.com/flarum/core/pull/927

rahul

After reading the entire post, I followed the instructions.

Adding my view as well. Instead of giving random name to avatars.

Changing line 115 of :
flarum\vendor\flarum\core\src\Core\Command\UploadAvatarHandler.php
from

   $uploadName = Str::lower(Str::quickRandom()).'.jpg';

I decided to give date as prefix for security reason

   $uploadName = 'avatar_'.date('d-m-Y').'.jpg';

Or you can add whatever you want.

[deleted]

I am running php 5.5 and it seems to work

« Previous Page