Remove space in rel=" nofollow ugc"

BharathPeace

@luceos I want to remove space in this rel=" nofollow ugc" change to rel="nofollow ugc" . Where can I edit this code?

clarkwinkelmann

BharathPeace short answer is unfortunately you can't. Because that rel attribute is set by Flarum after the Configuring event, so extensions can't alter it https://github.com/flarum/core/blob/d492579638fb52dafbfe65f1f36a95eb6047f7f3/src/Formatter/Formatter.php#L127

Why would you need to remove the space though ?

The reason there's a space is to separate anything extensions might have set already. The code could be changed to not add the unnecessary space of $rel is empty.

BharathPeace

clarkwinkelmann I want to change. Please help me.

askvortsov

BharathPeace as Clark mentioned above there isn't a simple way to change this via extensions. Perhaps if you could explain why you need this change, we could help you find an alternate solution?

BharathPeace

askvortsov Bcoz Seo. Google denies this type of link. I want to change the correct procedure.

BharathPeace

I do not ask custom theme or plugin from you. I need to change the correct procedure in attribute link.

luceos

clarkwinkelmann short answer is unfortunately you can't. Because that rel attribute is set by Flarum after the Configuring event, so extensions can't alter it https://github.com/flarum/core/blob/d492579638fb52dafbfe65f1f36a95eb6047f7f3/src/Formatter/Formatter.php#L127

a trim() around that code should solve it 🤔

clarkwinkelmann

BharathPeace Google change their behavior based on whether the attribute value starts with a space or not ? I've never heard about that. Is there somewhere I can read more about it ?

The only solutions to actually do it in the current Flarum version would be to fork Flarum core locally and make a manual change to the code, but this will make updates complicated in the future. Or create an extension that extends the formatter classes in the IOC container to apply changes to the formatter after the Flarum event.

Or you could submit a PR to core to change the behavior and we can merge it in a future Flarum release.

BharathPeace

luceos This code worked for me. But I have a doubt. that is - in future will I get any problem with this code?

protected function configureExternalLinks(Configurator $configurator)
{
    $dom = $configurator->tags['URL']->template->asDOM();
    foreach ($dom->getElementsByTagName('a') as $a) {
        $rel = $a->getAttribute('rel');
        $rel = trim(nofollow);
        $a->setAttribute('rel',"$rel ugc");
    }

    $dom->saveChanges();
}

clarkwinkelmann

BharathPeace if you edited files in vendor, expect the changes to be reverted anytime you run a Composer command.