Hello Flarum Core Developers,
I have noticed a minor bug in a clash of {userID} vs {numericUSERNAME}, I searched the forums and couldn't find a similar issue report, so I created one.
I noticed this issue when I saw @010101 (Billy's) username here on Flarum.
If you visit Billy's Profile by clicking this 👉🏽@010101 you see his own personal profile but if you refresh the browser it turns to @dkio 's profile and the slug remains the same because @dkio has the userID(10101) which matches with 010101 numerically.
To escalate the issue; if I try to sign up on Flarum Discuss with @dkio 's userID(10101) using "10101" as username I am still allowed to.
In a bid to find out if this was really an issue, I compared the issue on Twitter where I tried to change my username to my userID, but then; they already have a prepared message for that.
"Your username must include at least one letter.❗" 😂
Note: Some usernames on Twitter are in an all numeric format but all the ones I saw are very very old accounts, which means probably a later update disallowed the use of all numeric format in usernames, I don't know how true that is, I am just guessing. But I don't think Twitter should have any problem if they allowed all numeric format usernames since they don't allow userID in slugs.
Suggestions: I think Flarum should adopt this ValidationException to avoid a clash of {userID} vs {numericUSERNAME}, since Flarum allows {userID} in slugs, all this happens because the {userID} overrides the {userNAME} in user slug.
OR
Better still the problem can be solved by allowing {userNAME} to override {userID} in user slug.
Which ever way the core devs see it better! 🤷🏽♂️
Edit: 🙏🏽@010101 and 🙏🏽@dkio sorry for the needless mentions, I just had to explain the issue in a better way. Thanks.🤝🏽
