Inconsistent discussion posts count

matteocontrini

Hello,
I have a quite large discussion on my forum (https://forum.fibra.click/d/6189-disservizio-fibracity-aprile-2020), which should now have more than 2000 posts.

In the discussion page I see 2047 posts:

https://imgur.com/a/uywVIsr

But on the homepage the indicator says "1K" posts. If I look at what the API returns I see that it says 1999 posts.

https://imgur.com/a/kqiUGFw

I guess this is related to whether the count includes deleted and "event" posts, but I think the count should be consistent.

Moreover, I don't think that showing 1K posts when the posts are 1999 is a good idea.

Any thoughts?

matteocontrini

Ok, so now I've added the 2000th message and it still says 1K.

https://imgur.com/a/rD32nez

luceos

{abbreviateNumber(discussion[showUnread ? 'unreadCount' : 'replyCount']())}

export default function abbreviateNumber(number) {
  // TODO: translation
  if (number >= 1000000) {
    return Math.floor(number / 1000000) + app.translator.trans('core.lib.number_suffix.mega_text');
  } else if (number >= 1000) {
    return Math.floor(number / 1000) + app.translator.trans('core.lib.number_suffix.kilo_text');
  } else {
    return number.toString();
  }
}

Not sure what is causing this yet.

matteocontrini

luceos Math.floor(number / 1000)

If it's taking "2000" as the value it should give 2K indeed 🤔

luceos

I just verified this against the Bokt.nl Flarum staging environment running beta 13 and even though I have no round number, all values seem to be correct 🤔

matteocontrini

luceos now it says 2K and the comments count is 2004. I guess the code subtracts something from that number? An improvement would be to show something like "1.9K" instead of "1K". That would be better in these cases.

Anyway, the count is still inconsistent because when I open the discussion I see 2052, not 2004. I think the two numbers should be the same, whatever way they're calculated.

clarkwinkelmann

The number of posts shown on the homepage is the total of public, non-deleted comments. This value is cached for performance and is the same for all users.

The number of posts shown in the scrubber at the right of the discussion is the total number of posts your user can see in this discussion, which can include deleted posts and will include event posts if there are any. This value is not cached and will differ for each user.

matteocontrini

clarkwinkelmann thanks. So is the value on the homepage the "commentCount"? Do you have an idea of why it was showing 1K even whent the value was 2000?

clarkwinkelmann

matteocontrini the homepage shows replyCount, which is a computed value based on commentCount. The computation is commentCount - 1 https://github.com/flarum/core/blob/89ef14faf13e4d661ee9f4f636a32578c73bf760/js/src/common/models/Discussion.js#L22

So I suppose once you reach 2001 comments, replyCount will be 2000 and will abbreviate as 2K