Problems trying to set different canonical URL

pedrorezende

Hi everyone,

I have a Flarum embed on my main website (example.com) loading the comments from specific forum discussions. So for those discussions on Flarum I want to set my<link rel="canonical"> to point to example.com, in order to avoid duplicated content on Google.

So I created an extension, defined the observer for (new Extend\Frontend('forum'))->content(AnotherNiceComponent::class), created the proper logic and set the canonicalUrl on Flarum Document. So good, so far.

However, on Flarum\Frontent\Frontend @ $this->content[] (line 62), my callback is executed right before Flarum\Forum\Content\Discussion, so the canonicalUrl I defined got overwritten on line 92 of this Discussion class.

Is there a way to change the order / priority for those callbacks?

Thank you!

clarkwinkelmann

pedrorezende unfortunately, this seems to be a shortcoming of Flarum design.

The Frontend extender registers content callbacks through $container->resolving('flarum.frontend.forum'), but the route definition (through RouteHandlerFactory::toFrontend) resolves the frontend with $container->make('flarum.frontend.forum') before adding the base content callback.

This means the Content\Discussion will always run last, whatever way we use to add the callback.

This is probably worth a Flarum issue. We need to change it.

In the meantime I think the only solution would be to use a middleware to change the response HTML on the fly.

pedrorezende

Thanks, @clarkwinkelmann ! I'll post an issue on Github then