Sourcemaps with flarum-gulp

dvdoto

How can I generate the sourcemaps when using the Flarum Gulp wrapper ?

datitisev

dvdoto Flarum-gulp doesn't minify (I think)
It just transfers the code to babelHelpers... etc

If you look at assets/forum-XXXXXX.js you WILL see it minified, but I think those files in assets are the only ones.

Sorry if I got this wrong.

dvdoto

datitisev I'm not talking about the compiled files.
The core and each extension has it's own dist directory with the compiled JavaScript. For that I want to be able to generate the sourcemaps.

Toby

Actually, datitisev is right – flarum-gulp doesn't minify, so I'm not sure how this would work. Minification is done by PHP, so the sourcemaps would need to be generated there I suppose... Not sure if that's possible.

Toby

flarum-gulp currently doesn't have this functionality, but it's definitely something we'd be glad to merge a pull request for!

luceos

Toby I wouldn't be surprised if it is no issue at all if the compiled resources are already minified before being handled by PHP. You'd have sourcemaps for each dist file seperately then though, not sure whether @dvdoto wants it that way.

dvdoto

I got it working with gulp-sourcemaps:

gulp.src(src)
    .pipe(sourcemaps.init())  // <-

and

return stream.done()
      .pipe(concat(path.basename(options.outputFile), {newLine: ';\n'}))
      .pipe(sourcemaps.write()) // <-
      .pipe(gulp.dest(path.dirname(options.outputFile)));

This will of course work per extension and not when all the scripts are combined in the flarum-*.js file, but will do for the moment.