Strange statistics

kalucky0

I'm not entirely sure what is happening here, I'm suspecting that integers are casted to strings and concatenated with previous number. I hope this will get fixed in upcomming update,

[deleted]

I had the same issue. Someone told me it must be related to shared hosting I was using. Not sure is that also in this case.

kalucky0

I'm also using shared hosting. Is there any way to fix this?

tankerkiller125

kalucky0 This is likely related to some setting that your shared hosting vendor has set for the PHP install in order to reduce CPU/RAM usage. It's very common for shared hosting providers to overprovision their servers and then make changes to the settings that are detrimental to performance and in some cases even the operation of PHP programs. Unfortunately there is nothing the Flarum team can do in order to resolve this issue.

rob006

tankerkiller125 I would say that it is impossible that that some RAM/CPU cap would result such bug. It may slow things down or fail completely due to request timeout or exceeding memory limit, but it definitely should not return garbage - it that case it is software fault.

On quick look it looks like in some cases + is treated as string concatenation instead of arithmetic addition: https://github.com/flarum/statistics/blob/c6b996baa522249af3d40e301ea6324d399fa5c0/js/src/admin/components/StatisticsWidget.js#L179. I'm not sure why, but it should be easily fixable by explicit cast to int.

tankerkiller125

rob006 I have seen bugs like this appear in other software, notably when the shared hosting platform decreases the accuracy of float/int operations. Even when dealing with single no decimal numbers.

rob006

tankerkiller125 I have seen bugs like this appear in other software, notably when the shared hosting platform decreases the accuracy of float/int operations.

How this is even possible? Integer range depends on platform (64 or 32 bits), same for float, precision may only matter when you're converting float to string, but in that case you may get less precise result (like 3.3333 instead of 3.333333333333), not numbers out of space 😉.

tankerkiller125

rob006 I've seen some really strange things happen on shared hosting, many times with no reasonable explanation as to why. I'm sure we'd be open to a PR that cast it as an int to see if that resolves the issue.