Need help with Validation

Nearata

Ok, i'll go straight to the point.

AddValidatorRule.class

if ($event->type instanceof \Flarum\User\UserValidator) {
    $event->validator->addRules([
        'confirmPassword' => [
            'required'
        ]
    ]);
}

The error The confirm password field is required. appears. Ok.

Just typing letters in the field, the same error appears. Not ok.

I check the data sent to the /register route and confirmPassword is present. Then i decided to add a ValidationException in my class just to debug

throw new ValidationException([
    'confirmPassword' => $event->validator->attributes()['confirmPassword']
]);

but, sadly, a wild Undefined index: confirmPassword appears.

I also tried the suggestion of @clarkwinkelmann of using the getRules() / addRules() trick, nothing changes.

At this point, i don't know what's going on here.

clarkwinkelmann

Nearata the validator is fed with the user's Eloquent model attributes as well as the input $password before it's hashed here https://github.com/flarum/core/blob/v0.1.0-beta.13/src/User/Command/RegisterUserHandler.php#L106

It won't have access to confirmPassword unless you push it as a user attribute, but if you do that you'll then have to remove it again or it will try to save it to the database in a column that has the same name.

It seems my suggestion of using the confirmed validation rule from the other thread is not actually a possibility here as Flarum doesn't let us extend what's injected in the validator data.

I see two main solutions:

Not using a validator instance, and just comparing the data in the Saving event and manually throwing validation exceptions, like I think you're already doing in the extension
Create a new validator object in the Saving event, feed it with the two passwords data and do the extra validation there

SychO

clarkwinkelmann It seems my suggestion of using the confirmed validation rule from the other thread is not actually a possibility here as Flarum doesn't let us extend what's injected in the validator data.

I think you can though, using getData() and setData methods of the Illuminate Validator class, you could do something a little tricky like saving the password_confirmation value from the Saving event and using it to add it to the validator data in the Validating event.

Something like this

class CheckingConfirmPassword
{
    protected $password_confirmation;

    public function subscribe(Dispatcher $events)
    {
        $events->listen(Validating::class, [$this, 'addValidationRule']);
        $events->listen(Saving::class, [$this, 'addPasswordConfirmationField']);
    }

    public function addValidationRule(Validating $event)
    {
        if (! $event->type instanceof UserValidator) {
            return;
        }

        $rules = $event->validator->getRules();
        $rules['password'][] = 'confirmed';
        $event->validator->setRules($rules);

        $data = $event->validator->getData();
        $data['password_confirmation'] = $this->password_confirmation;
        $event->validator->setData($data);
    }

    public function addPasswordConfirmationField(Saving $event)
    {
        $this->password_confirmation = Arr::get($event->data, 'attributes.password_confirmation');
    }
}