First Post Approval

Anonymous65

Users subscribed to certain categories (FoF Follow Tags) are not receiving notifications for new discussions after they are approved.

clarkwinkelmann

Anonymous65 this is probably a problem with Flarum Approval in general, not just this extension. I don't think there is any mechanism in place to handle this. Follow Tags should implement its own logic to detect discussions changing approval state or visibility state.

peopleinside

Today a spammer profile has started to create 10 post / topic for seconds.
All was put in the moderation queue but a lot of email and alert and post to delete has been created.

Could you consider to add a number of max post that user can create and have in the moderation queue to forbid more topic or post creation until that are not approved?

clarkwinkelmann

peopleinside it's a great idea, but this should be its own extension.

There would be no overlap in code between my extension and such a feature. In fact such an extension would work great with the basic approval extension even if "first post approval" is not in use, so a separate extension would be more flexible.

peopleinside

Would be nice here just limitate the max number of queued post/topic an user can have 🙂 to avoid the spam profile to post 100 topics or post in the moderation queue that will generate a lot of content to delete and in my case even email notification.

I discovered that Flarum seems actually missing a flood protection for topics.

peopleinside

If a spam profile has spam message approved then deleted so topic and message of that user return to 0, First Post Approval should place again post and topic on moderation but this never happen.

clarkwinkelmann

peopleinside this is actually intentional behavior. The extension only counts how many posts/discussions have been approved so far, and doesn't watch over the content after the fact. This is so a user that has reached the threshold doesn't get back under the threshold just because a non-spam post was deleted for a legitimate reason.

Of course if the threshold was set very low, there could be reasons for wanting to reset/re-calculate the current value for a user. I'm not sure what would be most user-friendly though? I could add a button on a user profile for mods to reset or re-calculate. Or add an option in the post delete menu where mods can choose to delete only, or delete and rollback the approval count.

How often does that happen though? Was it caused by a moderator mistake?

peopleinside

Understood. A reset button will be nice also if maybe I suppose the admin can do something looking in the database 🙂
A reset button on the specific user profile will be nice 🙂

orcbin

Hello, I tried to approve a post today, however, I go to the post, it's all white, no other buttons and yeah. But on the whole list with discussions, it still got that hammer on the discussion marking it's not gained any approval yet.

And this was posted with my test user, and it sees the same thing as me. But if i go on other users, it doesn't see anything.

Admins & Mods can post without approval and shows up for everyone. And the DB is as bad too. 1 on private, 0 on approved.

clarkwinkelmann

orcbin there might be a conflict with another extension. If you know how to access the javascript console in the browser developer tools, check for any error message there. In any case, please share your php flarum info output.

orcbin

clarkwinkelmann Here you go, the output:


Flarum core: 1.8.10
PHP version: 8.4.8
MySQL version: 10.11.13-MariaDB-cll-lve
Loaded extensions: Core, date, libxml, openssl, pcre, sqlite3, zlib, bz2, calendar, ctype, curl, json, filter, ftp, gettext, hash, iconv, SPL, pcntl, random, readline, Reflection, session, standard, mbstring, shmop, SimpleXML, tokenizer, xml, i360, bcmath, dom, FFI, fileinfo, gd, intl, exif, mysqlnd, mysqli, PDO, pdo_mysql, pdo_sqlite, Phar, posix, sockets, xmlreader, xmlwriter, xsl,zip, ionCube Loader
+------------------------------------+---------+--------+
| Flarum Extensions                  |         |        |
+------------------------------------+---------+--------+
| ID                                 | Version | Commit |
+------------------------------------+---------+--------+
| flarum-flags                       | v1.8.2  |        |
| flarum-suspend                     | v1.8.4  |        |
| flarum-approval                    | v1.8.2  |        |
| flarum-tags                        | v1.8.4  |        |
| flarum-likes                       | v1.8.1  |        |
| afrux-forum-widgets-core           | v0.1.7  |        |
| the-turk-diff                      | 1.1.2   |        |
| sycho-profile-cover                | v1.3.5  |        |
| sycho-private-facade               | v0.1.16 |        |
| ramesh-dada-download-button        | v8.1.4  |        |
| nearata-maintenance-mode           | 1.0.0   |        |
| michaelbelgium-discussion-views    | v7.3    |        |
| malago-ads                         | 0.3.2   |        |
| kk14569-moderno                    | v1.0.3  |        |
| justoverclock-username-blacklist   | 0.1.0   |        |
| isamuraii-op-dark-mode-tuning      | 0.2     |        |
| gustjoha-swe                       | 1.1.1   |        |
| fof-user-bio                       | 1.4.2   |        |
| fof-upload                         | 1.8.3   |        |
| fof-terms                          | 1.4.2   |        |
| fof-oauth                          | 1.7.1   |        |
| fof-ban-ips                        | 1.1.2   |        |
| flarum-subscriptions               | v1.8.1  |        |
| flarum-sticky                      | v1.8.2  |        |
| flarum-statistics                  | v1.8.1  |        |
| flarum-mentions                    | v1.8.5  |        |
| flarum-markdown                    | v1.8.1  |        |
| flarum-lock                        | v1.8.2  |        |
| flarum-lang-spanish                | 1.12.0  |        |
| flarum-lang-russian                | 1.53.2  |        |
| flarum-lang-polish                 | v1.10.0 |        |
| flarum-lang-korean                 | v0.1.2  |        |
| flarum-lang-italian                | 1.17.0  |        |
| flarum-lang-german                 | 1.19.1  |        |
| flarum-lang-french                 | v4.29.0 |        |
| flarum-lang-english                | v1.8.0  |        |
| flarum-lang-dutch                  | v1.4.0  |        |
| flarum-lang-czech                  | v1.1.1  |        |
| flarum-lang-chinese-traditional    | v1.28.0 |        |
| flarum-lang-brazilian              | 1.7.2   |        |
| flarum-extension-manager           | v1.0.7  |        |
| flarum-emoji                       | v1.8.1  |        |
| flarum-bbcode                      | v1.8.0  |        |
| datitisev-post-galleries           | 1.1.1   |        |
| clarkwinkelmann-predefined-avatars | 1.0.1   |        |
| clarkwinkelmann-likes-received     | 1.0.2   |        |
| bryantmilan-lang-serbian           | v1.4.1  |        |
| blazite-turnstile                  | 1.0.0   |        |
| askvortsov-moderator-warnings      | v0.6.3  |        |
| afrux-top-posters-widget           | v0.1.5  |        |
| afrux-online-users-widget          | v0.1.9  |        |
| afrux-news-widget                  | v0.1.1  |        |
+------------------------------------+---------+--------+
Base URL: https://archive.orcbin.com/public
Installation path: /***/***/archive.orcbin.com
Queue driver: sync
Session driver: file
Scheduler status: Inactive
Mail driver: mail
Debug mode: off

orcbin

I just found out the same thing is happening to my Forum, the previous one was my Archive. So it seems like it isn't an error on my end only right??

jstebenne

orcbin I've been having the same issue with my forum and asked for help here: https://discuss.flarum.org/d/37610-approval-extension-posts-stuck-in-waiting-for-approval

The only thing that I know is that (at least for my forum) it is related to the "Approval" extension instead of "First Post Approval"

orcbin

jstebenne Yes, I have the same error as you with the Approval extension, I don't have the First Post Approval extension.

orcbin

clarkwinkelmann Are you gonna help or what?

KBExit

orcbin you need to chill out. @clarkwinkelmann will help you when he has the chance. He has a lot of other things in his life than just support one individual. He does this on the side and is not his sole purpose of life.

clarkwinkelmann

orcbin I don't have enough information at the moment. Things to try:

Open browser development tools > JavaScript console, check for any error appearing when clicking the link that results in a blank page.

Is the page still blank when First Post Approval is disabled? Once a post is flagged by my extension, everything related to showing posts that require approval and approving is managed by the native Approval extension. If the error is still there, then the problem is likely unrelated to my extension.

Reduce the number of extensions to a minimum and find steps to reproduce, so I can try on one of my test forums.

If you're really stuck and it happened only for a specific post and never reproduced, you can share admin credentials with me for your forum so I can take a look in my own browser (email address on my website).

orcbin

clarkwinkelmann Sorry for what I said, but I might be at the wrong post, I'm talking about the Approval Post, but i've tried First Approval too, and doesn't work. I don't catch any errors on the console at all.

One thing though, the DB shows 1 on private and 0 on Approved. Even after approving, so I have to change that manually and it'll work. No problem with staffs posting, it works absolutely fine.

giulio

First Post Approval is great, however it seems that once you install and enable it, it will ask for approval from existing users, even if they have more than one post already. That is suboptimal for forums with many existing users. I see the instructions here mention to manually edit first_post_approval_count and first_discussion_approval_count of the users table, but manually editing tables is not always easy and it's potentially dangerous.

Is it possible to add an option to automatically approve all existing users, or all existing users with more than X posts?

clarkwinkelmann

giulio I'm not planning to add such a feature at the moment.

Editing that column in the database is 100% safe, it's the only place where the state is held, so there's no risk of breaking anything. It's a good idea to have database backups in place though.

If you want to whitelist every single existing user, the SQL query to set the same value for everyone is very simple.

« Previous Page Next Page »