Removing a notification preference fails

Pollux

Customizing my forum I need to remove a notification preference.

app.initializers.add('me/myextension', () => {
  extend(NotificationGrid.prototype, 'notificationTypes', function (items) {
    console.log(items);
    items.remove('superfluousNotificationPreference');
  });
});

console.log(items) shows me, that superfluousNotificationPreference is indeed one of the items, but this item just doesn't get removed (differently from previous betas). There are no error messages in the console either.

clarkwinkelmann

Pollux is the item a core item or added by another extension? If it's added by another extension, the initializer priority will probably need to be changed to guarantee your code runs after the other extension.

console.log might not accurately reflect the state since most browsers will show the variable by reference, so the value you see might not be the value at the time the code runs. You can use a break point in the debugger, or log a primitive type that won't change by reference, like logging the output of items.has('name') or JSON.stringify(items)

Pollux

Great, this was exactly the problem. The item I want to remove was added by another extension and console.log(items.has('superfluousNotificationPreference')); returned false.

Changing my code to:

app.initializers.add('me/myextension', () => {
  extend(NotificationGrid.prototype, 'notificationTypes', function (items) {
    console.log(items);
    items.remove('superfluousNotificationPreference');
  });
}, -10);

... caused console.log(items.has('superfluousNotificationPreference')); to return true as well as my extension to work as desired.

PS: This would would probably have been handy in this case if it were compatible with the latest Flarum version. But I understand, that other tasks have a far higher priority than working on this extension.