{recipient_display_name} and {replier_display_name} mixed up?

Christoph8434

Hello everyone and a happy New Year!

When Bob replies to a post made by Alice and Alice is subscribed to this kind of notifications, the email that Alice receives reads as follows:

Subject: Alice replied to your post in Test
Body: Hey Alice!

Alice replied to your post (#1) in Test.

Obviously, this doesn't make sense. The email should instead read as follows:

Subject: Bob replied to your post in Test
Body: Hey Alice!

Bob replied to your post (#1) in Test.

As far as I can see, the relevant message keys are flarum-mentions.email.post_mentioned.subject and flarum-mentions.email.post_mentioned.body.

This issue occurs in 0.1.0-beta.15, irrespective of whether

the Nicknames extension is enabled or disabled,
the driver is set to username or nickname.

Regards
Christoph

IanM

Christoph8434 This indeed is a mix up between $this->reply and $this->post in the blueprints of flarum/mentions.

I submitted a PR to fix this, which has now been merged here flarum/mentions9abc434

I guess there are two options:
1) Wait for a new release of flarum/mentions, probably as part of the next (beta 16?) release
2) Edit these files in your vendor folder - carefully 😉 if you use this method, be warned that any future updates will overwrite any manual changes

JasperVriends

I actually noticed the same issue multiple times, but incidental. Sometimes it's correct and it displays the correct username, sometimes it's not.

Hadn't checked yet if there was a GitHub issue, but I'm glad I'm not the only one noticing it as I couldn't find any discussions about it 😛

clarkwinkelmann

So I took a quick look but I'm not sure where exactly the issue is. Some links:

The translations: https://github.com/flarum/lang-english/blob/327d12e29e0de7b3d8a4c9464ae2c85c2965201a/locale/flarum-mentions.yml#L43-L54

The mapping: https://github.com/flarum/mentions/blob/master/src/Notification/PostMentionedBlueprint.php

The instantiation of constructor parameters in the blueprint https://github.com/flarum/mentions/blob/ac1f8bc1eded71ff4a25b1edb78ff936976808f1/src/Listener/UpdateMentionsMetadataWhenVisible.php#L82

We could definitely do with more comments. I'm assuming $post is supposed to be your post, while $reply is the post that mentions your post.

I'm not sure if there's a mix up between $this->reply and $this->post in the blueprint, or if it's in the listener that the two got mixed up. The placement of the mappings in the translation does seem correct.

Christoph8434

IanM Thanks! I edited these files manually, and the notification email's subject and body are now correct.

Arnold

Oh, I'm glad that someone noticed this bug besides me 🙂
@IanM, thanks for the solution!

[deleted]

Christoph8434 looks like I'll need to do the same as I noticed this a few days back but forgot to report it.