Allow admin ONLY to start a discussion

ikramy

[deleted] Thanks, I did that but the user can still see the "Start Discussion" button and the text editor!

[deleted]

ikramy Did you clear the cache, and also ensure the affected user has actually logged out, and back in again ?

ikramy

[deleted] I did remove everything inside storage/cache, then logged out as an admin, and finally logged in as an admin again, but the issue remains!

[deleted]

ikramy If you are logging in as admin, then it will of course work, as the admin has the permission 🙂 You need to login as a user to test if this works or not

ikramy

[deleted] yes I forgot to mention that after that, I logged in as a normal user but I could still see the start discussion button. Thanks

askvortsov

Please share a screenshot of your full permissions page setup

ikramy

askvortsov

And you're saying that a regular logged in user can start a discussion, or just that the button appears?

[deleted]

The button should appear, but should include text that you can't post - that's how it works on my forum.

ikramy

The button appears to users, and they can see the editor and type title and content, but nothing happens when they click "post discussion", and no message appears. This is a bit confusing.

askvortsov

Any chance you could share a link to your site, as well as the output of php flarum info?

ikramy

askvortsov Site only or admin as well? I'm on shared hosting, not sure if I can run "php flarum info" but I will see if I can. Thanks

askvortsov

ikramy Just the site, I'd like to set up an account and test for myself. As to php flarum info, you should just run it in the terminal, in the same directory where there's a file called config.php and another fle called flarum

ikramy

askvortsov Hi, here it is

https://forum.popularstrategy.com/public/

ikramy

Okay, I followed the docs to write a simple extension to hide the "Start Discussion" button using CSS. But this hides the button for all types of users.

Is there a way to check if the currently logged-in user type is admin? Thanks

<?php

use Flarum\Extend;
use Flarum\Frontend\Document;

return [
(
new Extend\Frontend('forum'))
->content(function (Document $document){
$document->head[] = '<style>li.App-primaryControl.item-newDiscussion{display:none !important;}</style>';
}
)
];

clarkwinkelmann

ikramy not from CSS.

~~In the content extender you can access the actor through $document->request->getAttribute('actor'). EDIT: actually, not sure this works. The property appears to be protected.~~

In the content extender you can access the actor through the second parameter $request, like ->content(function (Document $document, ServerRequestInterface $request){ $request->getAttribute('actor'); })

If you want to hide the disabled button, there should be a class name on the button you can look for in CSS.

If the disabled state is missing from the button when it should be present, it would be fantastic to fix it in Flarum and submit a PR 🤗 But reading the discussion I don't really understand what's going on. If there an issue, are you able to share steps so we can reproduce on a new Flarum install?

If the bug isn't reproductible on a new Flarum install it would be best to try and find which extension is causing it instead of creating a workaround for an issue of unknown origin.

ikramy

clarkwinkelmann Thank you so much, this works now. But one last thing, please. How do I check if the actor is admin or not? Can I just rely on the group ID?

"groups": [
{
"id": 1,
"name_singular": "Admin",
"name_plural": "Admins",
"color": "#B72A2A",
"icon": "fas fa-wrench",
"is_hidden": 0,
"pivot": {
"user_id": 1,
"group_id": 1
}
}
]

Thanks

clarkwinkelmann

ikramy ideally, you should use a gate/policy and query it with $actor->can('ability'). There's also $actor->isAdmin() and as a last resort yes, group ID 1 is hard-coded as the admin group.

ikramy

clarkwinkelmann Thank you very much