Composer.json metadata

Kakifrucht

This is in regards to this info: https://docs.flarum.org/extend/admin.html#composer-json-metadata

I couldn't find any information about the (new?) "info" key under "flarum-extension". lang-english seems to use it for it's donation link, since there is no funding category there (this possibility is also missing in linked table). The other two entries under "website" and "support" don't seem to be taken into account at all, why were they added?

The table in the docs seems to also miss author information, since author names and their emails under the "authors" key are also being parsed by Flarum.

Ralkage

Kakifrucht The table in the docs seems to also miss author information, since author names and there emails under the "authors" key are also being parsed by Flarum.

These properties are noted in this section of the composer.json Scheme page mentioned in the Flarum docs 🙂

Kakifrucht

Ralkage Yes, but there is no mention that this information is being parsed and added to the plugins admin section. I feel like this is something the linked doc should mention, since the table explicitly lists all keys that are shown in the extensions admin screen.

Kakifrucht

Paging @Kyrne since you added those keys: flarum/lang-english733e8b9 (diff)
Can you elaborate what they are for? Was this maybe from a previous implementation of the Admin UX feature that was dropped and it now uses the standard composer keys instead?

askvortsov

Kakifrucht these allow you to override the default composer ones, if for some reason, you want to have different data showing up in your composer.json and on the admin dashboard

Kakifrucht

askvortsov Yes, the funding link seems to override properly, however both the "website" and "support" keys don't. No website nor support link is displayed on the extension admin page for the English pack.

askvortsov

Ah, got it. Towards the end of the admin UX redesign, the key was changed from info to links, which we thought more accurate, but the English lang pack was never updated to use the new key (although tbh it should be using the regular composer attrs).