Flarum Discussion Views

MichaelBelgium

Justoverclock Should be something like this, but didn't push this to the repository yet

imgur

Justoverclock

MichaelBelgium really nice! i prefer this version

MichaelBelgium

After some tweaking a new version has been released!

v7.1.0

Added features:

footer viewlist (and setting) - an alternative to the sidebar viewlist

Imgur
imgur

Tracking guests is now an option/setting

Imgur

quite some new translation keys has been added

Difference between the footer viewlist and sidebar viewlist

does not display guests
Increasing the max viewlist items won't affect that much and neither use a lot of space like in the sidebar viewlist
does not show multiple views per user - if a user viewed it 3 times, the user will only be displayed once

Full changelog

Please open an issue on github if you hit mistakes or bugs!

m4v3rick

MichaelBelgium Please open an issue on github if you hit mistakes or bugs!

I have no github account yet, but enabling "Enable footer viewlist" breaks discussion and shows no more posts.
Disabling and refreshing and posts are back.

mount-redraw.js:15 TypeError: Cannot read properties of undefined (reading 'id') at e.<anonymous> (AddLists.js:56) at e.forEach.t.<computed> [as footerItems] (extend.js:35) at e.n.view (Post.js:75) at Function.a (render.js:30) at render.js:155 at render.js:160 at l (render.js:66) at u (render.js:50) at render.js:134 at l (render.js:63)

Justoverclock

@MichaelBelgium did u see this if is related to your extension?
https://discuss.flarum.org/d/28956-cannot-read-properties-of-undefined-reading-id-when-access-to-posts-page/5

MichaelBelgium

Justoverclock Yes it is, thats fixed now @datlechin

MichaelBelgium

m4v3rick Fixed in v7.1.1

raygerx You might need to change css styles for the discussion counter

m4v3rick

m4v3rick "Enable footer viewlist" breaks discussion

Still a bug.

raygerx

how to fix this?

the number of the counter staying on another place, only in Asirem Theme

datlechin

In the input Maximum listview items, can you make it default value of 0 then the listview items will not be limited.

MichaelBelgium

datlechin That has the possibility to slow down your forum a lot! U should be careful with that. U can set the limit to 999999 or whatev, that's "unlimited" too

m4v3rick Ok based on the error I changed something, but i'm not sure if that's the fix. Can u test it out? Pull in the dev-master branch

ctml

I know this follows the same UI as likes extension, but I think it would be nice to have an option for both to view this list using small avatars so that they'd be more condensed and you could fit more users w/tooltip on hover.

m4v3rick

MichaelBelgium Fixed in v7.1.1

Tried
composer update michaelbelgium/flarum-discussion-views php flarum migrate php flarum cache:clear

Bug still exists.

raygerx

MichaelBelgium

I've turned off the plugin which was changed the position of the discussion view plugin.

MichaelBelgium

m4v3rick What page you trying to view?

HasanMerkit

raygerx same problem :/

m4v3rick

MichaelBelgium

Any discussion page.

MichaelBelgium

m4v3rick Can't reproduce that issue, what does php flarum info say?

m4v3rick

MichaelBelgium

Sorry for the late reply - i've been on holidays. 😉

Flarum core 1.0.4 PHP version: 8.0.8 Loaded extensions: Core, date, libxml, openssl, pcre, zlib, filter, hash, json, pcntl, Reflection, SPL, session, standard, sodium, mysqlnd, PDO, xml, calendar, ctype, curl, dom, mbstring, FFI, fileinfo, ftp, gettext, iconv, exif, mysqli, pd o_mysql, Phar, posix, readline, shmop, SimpleXML, sockets, sysvmsg, sysvsem, sys vshm, tokenizer, xmlreader, xmlwriter, xsl, Zend OPcache +---------------------------------+--------------+--------+ | Flarum Extensions | | | +---------------------------------+--------------+--------+ | ID | Version | Commit | +---------------------------------+--------------+--------+ | flarum-flags | v1.0.0 | | | afrux-forum-widgets-core | v0.1.3 | | | flarum-tags | v1.0.3 | | | flarum-subscriptions | v1.0.0 | | | flarum-approval | v1.0.0 | | | flarum-suspend | v1.0.0 | | | fof-spamblock | 1.0.0 | | | flarum-likes | v1.0.0 | | | flarum-markdown | v1.0.1 | | | justoverclock-emoticonpack | 0.1.1 | | | justoverclock-last-users-posts | 0.2.2 | | | fof-share-social | 1.0.0 | | | fof-discussion-thumbnail | 1.0.1 | | | kyrne-whisper | 0.1.3 | | | ianm-level-ranks | 1.0.0 | | | sycho-move-posts | v0.1.5 | | | fof-follow-tags | 1.0.1 | | | acpl-mobile-tab | 1.0.5 | | | justoverclock-guestengagement | 1.0.2 | | | justoverclock-contactme | 0.2.0 | | | afrux-forum-stats-widget | v0.1.0 | | | fof-default-user-preferences | 1.0.0 | | | fof-ignore-users | 1.0.0 | | | fof-forum-statistics-widget | 1.0.0 | | | fof-byobu | 1.0.0-beta.7 | | | fof-bbcode-details | 1.0.0 | | | flarum-emoji | v1.0.0 | | | flarum-bbcode | v1.0.0 | | | fof-stopforumspam | 1.0.0 | | | fof-user-directory | 1.0.2 | | | fof-merge-discussions | 1.0.0 | | | fof-pages | 1.0.1 | | | fof-username-request | 1.0.0 | | | flarum-lang-german | 1.1.4 | | | fof-linguist | 1.0.0 | | | clarkwinkelmann-circle-groups | 1.0.0 | | | flarum-mentions | v1.0.0 | | | flarum-lock | v1.0.0 | | | clarkwinkelmann-likes-received | 1.0.0 | | | askvortsov-moderator-warnings | v0.6.0 | | | flarum-sticky | v1.0.0 | | | flarum-lang-english | v1.0.0 | | | flarum-lang-french | v3.0.0 | | | flarum-statistics | v1.0.0 | | | therealsujitk-gifs | v4.1.0 | | | fof-nightmode | 1.0.0 | | | fof-sitemap | 1.0.0 | | | fof-upload | 1.0.1 | | | fof-split | 1.0.0 | | | michaelbelgium-discussion-views | v7.1.1 | | | fof-ban-ips | 1.0.0 | | | fof-cookie-consent | 1.0.0 | | | fof-formatting | 1.0.0 | | | fof-links | 1.0.0 | | | fof-disposable-emails | 1.0.0 | | | the-turk-flamoji | 1.0.2 | | | fof-drafts | 1.0.1 | | | askvortsov-categories | v3.0.0 | | | justoverclock-discussion-info | 0.1.1 | | | fof-pretty-mail | 1.0.1 | | | fof-analytics | 1.0.0 | | +---------------------------------+--------------+--------+

m4v3rick

MichaelBelgium Ok based on the error I changed something, but i'm not sure if that's the fix. Can u test it out? Pull in the dev-master branch

Just tried it. Still breaks the discussion but not every discussion breaks now. 2 out of 6.
I made a few checks and realized that whenever my other test user has a post inside the discussion, the refresh fails. If i delete the post it works.
Does that help?
Refresh works with the posts of the user if i disable "Enable footer viewlist".

m4v3rick

Sivoph This should work for you now, @m4v3rick . Requirement has been added to OP.

Can confirm that an error message is thrown and UI won't break anymore. But why does it need Discussion views. The extension caused some performance issues and activating "Enable footer viewlist" breaks my discussions still.

chinestroza03 it does not load me so that a rating can be made

Same problem here.
Migrate and cache. Still not working. I see the empty line beneath the header.

@Sivoph

See that post:

m4v3rick Just tried it. Still breaks the discussion but not every discussion breaks now. 2 out of 6.
I made a few checks and realized that whenever my other test user has a post inside the discussion, the refresh fails. If i delete the post it works.
Does that help?
Refresh works with the posts of the user if i disable "Enable footer viewlist".

This problem and performance issues is, why I keep it deactivated.

Radu

Hi there. I have a problem with this extension, cannot enable it.

What can I do?

Justoverclock

Radu any error in console?

MichaelBelgium

Radu Check the flarum log for the detailed error message.

AdOpser

Radu how do you fix it?

« Previous Page Next Page »