Flarum Discussion Views

Buildit

Whoa! I finally got this to work!

I originally had "Theme - Hub" enabled which I think was causing the conflict.

I reverted back to Base FreeFlarum, then injected your code @yotsuya and it worked. Then to test, I re-enabled "Theme - Hub", and it stayed working with the theme enabled. Yay! 🥳

But if I added @yotsuya 's code while the Theme was on, the counters would not stack. Interesting behavior. Hope this helps others. Thanks man! 🙏

MichaelBelgium

v7.4

IPv6 support
Improved styling
Marked fof/discussion-views as conflict
More usage of displayname instead of username

Full Changelog: MichaelBelgium/flarum-discussion-viewsv7.3 → v7.4

I hope this update fixes styling once and for all, the view counter element is now set to absolute. After updating, check if your custom css conflicts with it or not (just remove your custom css for the view counter element if it does)

mafesa

MichaelBelgium this is what I see on mobile devices.

Default theme without CSS modifications.

MichaelBelgium

mafesa Aight, thanks for that screenshot! Tagged 7.4.1 which should fix overlapping (also added a bit of margin-top)

Buildit

MichaelBelgium

Thanks for your work man. I had mobile alignment fixed via CSS before, with the eyeball icon present. Yours does fix the mobile alignment naturally, but I lose the eyeball icon. Not the end of the world, but the icon is helpful. I know it's a PIA.

This was the working CSS that I had is here, if it helps. Thanks again for your efforts.

// Discussion Views - Mobile Discussion List
@media (max-width: 767px) {
.DiscussionListItem-main {
padding-right: 5px;
}
.DiscussionListItem-main .item-discussion-views {
position: absolute;
right: 80px;
top: 37px;
}
.DiscussionListItem-count:before {
-moz-osx-font-smoothing: grayscale;
-webkit-font-smoothing: antialiased;
display: inline-block;
font-style: normal;
font-variant: normal;
text-rendering: auto;
line-height: 1;
font-family: 'Font Awesome 5 Free';
font-weight: 400;
content: "\f075";
margin-right: 5px;
}
}

Henrie

Hi all,

I did not change thing, but on a regular PC (not mobile) the view count shifts to right now, out of position.
Little change / bug in a new update?

How can I fix this?
Or can you fix this?

See Image for how it looks now.
Thanks in advance.

https://mega.nz/file/vEF3CBoC#xA_LxILIRDn6U7c9t0Zote6msrKsUBeRrLvVmxj6goU

MichaelBelgium

Buildit If you want the icon back you can add this in custom styles

Not sure if you use @phone too or just media query:

@media (max-width: 767px) {
    .item-discussion-views .icon {
        display: inline-block;
    }
}

Henrie Do you have custom styles? A theme?

The update fixes default styling

qishou

@MichaelBelgium

Stack trace:
#0 /vendor/composer/ClassLoader.php(427): Composer\Autoload\{closure}()
#1 [internal function]: Composer\Autoload\ClassLoader->loadClass()
#2 /vendor/illuminate/container/Container.php(877): ReflectionClass->__construct()
#3 /vendor/illuminate/container/Container.php(758): Illuminate\Container\Container->build()
#4 /vendor/illuminate/container/Container.php(694): Illuminate\Container\Container->resolve()
#5 /vendor/flarum/core/src/Foundation/ContainerUtil.php(28): Illuminate\Container\Container->make()
#6 /vendor/flarum/core/src/Api/Controller/AbstractSerializeController.php(121): Flarum\Foundation\ContainerUtil::Flarum\Foundation\{closure}()
#7 /vendor/flarum/core/src/Http/RouteHandlerFactory.php(41): Flarum\Api\Controller\AbstractSerializeController->handle()
#8 /vendor/flarum/core/src/Http/Middleware/ExecuteRoute.php(27): Flarum\Http\RouteHandlerFactory->Flarum\Http\{closure}()
#9 /vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\ExecuteRoute->process()
#10 /vendor/mattoid/flarum-ext-money-history-auto/src/Middleware/UserSaveMiddleware.php(41): Laminas\Stratigility\Next->handle()
#11 /vendor/laminas/laminas-stratigility/src/Next.php(49): Mattoid\MoneyHistoryAuto\Middleware\UserSaveMiddleware->process()
#12 /vendor/mattoid/flarum-ext-money-history-auto/src/Middleware/TransferHistoryMiddleware.php(38): Laminas\Stratigility\Next->handle()
#13 /vendor/laminas/laminas-stratigility/src/Next.php(49): Mattoid\MoneyHistoryAuto\Middleware\TransferHistoryMiddleware->process()
#14 /vendor/mattoid/flarum-ext-money-history-auto/src/Middleware/MoneyRewardsMiddleware.php(39): Laminas\Stratigility\Next->handle()
#15 /vendor/laminas/laminas-stratigility/src/Next.php(49): Mattoid\MoneyHistoryAuto\Middleware\MoneyRewardsMiddleware->process()
#16 /vendor/mattoid/flarum-ext-money-history-auto/src/Middleware/DistributeAllHistoryMiddleware.php(36): Laminas\Stratigility\Next->handle()
#17 /vendor/laminas/laminas-stratigility/src/Next.php(49): Mattoid\MoneyHistoryAuto\Middleware\DistributeAllHistoryMiddleware->process()
#18 /vendor/flarum/core/src/Api/Middleware/ThrottleApi.php(33): Laminas\Stratigility\Next->handle()
#19 /vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Api\Middleware\ThrottleApi->process()
#20 /vendor/flarum/core/src/Http/Middleware/CheckCsrfToken.php(36): Laminas\Stratigility\Next->handle()
#21 /vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\CheckCsrfToken->process()
#22 /vendor/flarum/core/src/Http/Middleware/ResolveRoute.php(69): Laminas\Stratigility\Next->handle()
#23 /vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\ResolveRoute->process()
#24 /vendor/flarum/core/src/Http/Middleware/SetLocale.php(51): Laminas\Stratigility\Next->handle()
#25 /vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\SetLocale->process()
#26 /vendor/flarum/core/src/Http/Middleware/AuthenticateWithHeader.php(58): Laminas\Stratigility\Next->handle()
#27 /vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\AuthenticateWithHeader->process()
#28 /vendor/flarum/core/src/Http/Middleware/AuthenticateWithSession.php(31): Laminas\Stratigility\Next->handle()
#29 /vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\AuthenticateWithSession->process()
#30 /vendor/flarum/core/src/Http/Middleware/RememberFromCookie.php(63): Laminas\Stratigility\Next->handle()
#31 /vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\RememberFromCookie->process()
#32 /vendor/flarum/core/src/Http/Middleware/StartSession.php(61): Laminas\Stratigility\Next->handle()
#33 /vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\StartSession->process()
#34 /vendor/flarum/core/src/Api/Middleware/FakeHttpMethods.php(29): Laminas\Stratigility\Next->handle()
#35 /vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Api\Middleware\FakeHttpMethods->process()
#36 /vendor/flarum/core/src/Http/Middleware/ParseJsonBody.php(28): Laminas\Stratigility\Next->handle()
#37 /vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\ParseJsonBody->process()
#38 /vendor/flarum/core/src/Http/Middleware/HandleErrors.php(57): Laminas\Stratigility\Next->handle()
#39 /vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\HandleErrors->process()
#40 /vendor/flarum/core/src/Http/Middleware/InjectActorReference.php(25): Laminas\Stratigility\Next->handle()
#41 /vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\InjectActorReference->process()
#42 /vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(75): Laminas\Stratigility\Next->handle()
#43 /vendor/middlewares/request-handler/src/RequestHandler.php(84): Laminas\Stratigility\MiddlewarePipe->process()
#44 /vendor/laminas/laminas-stratigility/src/Next.php(49): Middlewares\RequestHandler->process()
#45 /vendor/middlewares/base-path-router/src/BasePathRouter.php(99): Laminas\Stratigility\Next->handle()
#46 /vendor/laminas/laminas-stratigility/src/Next.php(49): Middlewares\BasePathRouter->process()
#47 /vendor/laminas/laminas-stratigility/src/Middleware/OriginalMessages.php(36): Laminas\Stratigility\Next->handle()
#48 /vendor/laminas/laminas-stratigility/src/Next.php(49): Laminas\Stratigility\Middleware\OriginalMessages->process()
#49 /vendor/middlewares/base-path/src/BasePath.php(73): Laminas\Stratigility\Next->handle()
#50 /vendor/laminas/laminas-stratigility/src/Next.php(49): Middlewares\BasePath->process()
#51 /vendor/flarum/core/src/Http/Middleware/ProcessIp.php(24): Laminas\Stratigility\Next->handle()
#52 /vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\ProcessIp->process()
#53 /vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(75): Laminas\Stratigility\Next->handle()
#54 /vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(64): Laminas\Stratigility\MiddlewarePipe->process()
#55 /vendor/laminas/laminas-httphandlerrunner/src/RequestHandlerRunner.php(73): Laminas\Stratigility\MiddlewarePipe->handle()
#56 /vendor/flarum/core/src/Http/Server.php(45): Laminas\HttpHandlerRunner\RequestHandlerRunner->run()
#57 /public/index.php(26): Flarum\Http\Server->listen()
#58 {main}

Could you please tell me how to solve this problem?

clarkwinkelmann

qishou can you describe the problem? What action leads to an error? What do you see or not see?

Your php flarum info output would be useful https://docs.flarum.org/troubleshoot

The text you shared is only part of an error message. Critically, it's missing the very first line which contains the most important elements.

qishou

clarkwinkelmann

flarum.ERROR: ParseError: syntax error, unexpected identifier "SettingsRepositoryInterface", expecting variable in /vendor/michaelbelgium/flarum-discussion-views/src/Listeners/AddDiscussionViewHandler.php:21
Stack trace:
#0 /vendor/composer/ClassLoader.php(427): Composer\Autoload\{closure}()
#1 [internal function]: Composer\Autoload\ClassLoader->loadClass()
#2 /vendor/illuminate/container/Container.php(877): ReflectionClass->__construct()
#3 /vendor/illuminate/container/Container.php(758): Illuminate\Container\Container->build()
#4 /vendor/illuminate/container/Container.php(694): Illuminate\Container\Container->resolve()
#5 /vendor/flarum/core/src/Foundation/ContainerUtil.php(28): Illuminate\Container\Container->make()
#6 /vendor/flarum/core/src/Api/Controller/AbstractSerializeController.php(121): Flarum\Foundation\ContainerUtil::Flarum\Foundation\{closure}()
#7 /vendor/flarum/core/src/Http/RouteHandlerFactory.php(41): Flarum\Api\Controller\AbstractSerializeController->handle()
#8 /vendor/flarum/core/src/Http/Middleware/ExecuteRoute.php(27): Flarum\Http\RouteHandlerFactory->Flarum\Http\{closure}()
#9 /vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\ExecuteRoute->process()
#10 /vendor/mattoid/flarum-ext-money-history-auto/src/Middleware/UserSaveMiddleware.php(41): Laminas\Stratigility\Next->handle()
#11 /vendor/laminas/laminas-stratigility/src/Next.php(49): Mattoid\MoneyHistoryAuto\Middleware\UserSaveMiddleware->process()
#12 /vendor/mattoid/flarum-ext-money-history-auto/src/Middleware/TransferHistoryMiddleware.php(38): Laminas\Stratigility\Next->handle()
#13 /vendor/laminas/laminas-stratigility/src/Next.php(49): Mattoid\MoneyHistoryAuto\Middleware\TransferHistoryMiddleware->process()
#14 /vendor/mattoid/flarum-ext-money-history-auto/src/Middleware/MoneyRewardsMiddleware.php(39): Laminas\Stratigility\Next->handle()
#15 /vendor/laminas/laminas-stratigility/src/Next.php(49): Mattoid\MoneyHistoryAuto\Middleware\MoneyRewardsMiddleware->process()
#16 /vendor/mattoid/flarum-ext-money-history-auto/src/Middleware/DistributeAllHistoryMiddleware.php(36): Laminas\Stratigility\Next->handle()
#17 /vendor/laminas/laminas-stratigility/src/Next.php(49): Mattoid\MoneyHistoryAuto\Middleware\DistributeAllHistoryMiddleware->process()
#18 /vendor/flarum/core/src/Api/Middleware/ThrottleApi.php(33): Laminas\Stratigility\Next->handle()
#19 /vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Api\Middleware\ThrottleApi->process()
#20 /vendor/flarum/core/src/Http/Middleware/CheckCsrfToken.php(36): Laminas\Stratigility\Next->handle()
#21 /vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\CheckCsrfToken->process()
#22 /vendor/flarum/core/src/Http/Middleware/ResolveRoute.php(69): Laminas\Stratigility\Next->handle()
#23 /vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\ResolveRoute->process()
#24 /vendor/flarum/core/src/Http/Middleware/SetLocale.php(51): Laminas\Stratigility\Next->handle()
#25 /vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\SetLocale->process()
#26 /vendor/flarum/core/src/Http/Middleware/AuthenticateWithHeader.php(58): Laminas\Stratigility\Next->handle()
#27 /vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\AuthenticateWithHeader->process()
#28 /vendor/flarum/core/src/Http/Middleware/AuthenticateWithSession.php(31): Laminas\Stratigility\Next->handle()
#29 /vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\AuthenticateWithSession->process()
#30 /vendor/flarum/core/src/Http/Middleware/RememberFromCookie.php(63): Laminas\Stratigility\Next->handle()
#31 /vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\RememberFromCookie->process()
#32 /vendor/flarum/core/src/Http/Middleware/StartSession.php(61): Laminas\Stratigility\Next->handle()
#33 /vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\StartSession->process()
#34 /vendor/flarum/core/src/Api/Middleware/FakeHttpMethods.php(29): Laminas\Stratigility\Next->handle()
#35 /vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Api\Middleware\FakeHttpMethods->process()
#36 /vendor/flarum/core/src/Http/Middleware/ParseJsonBody.php(28): Laminas\Stratigility\Next->handle()
#37 /vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\ParseJsonBody->process()
#38 /vendor/flarum/core/src/Http/Middleware/HandleErrors.php(57): Laminas\Stratigility\Next->handle()
#39 /vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\HandleErrors->process()
#40 /vendor/flarum/core/src/Http/Middleware/InjectActorReference.php(25): Laminas\Stratigility\Next->handle()
#41 /vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\InjectActorReference->process()
#42 /vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(75): Laminas\Stratigility\Next->handle()
#43 /vendor/middlewares/request-handler/src/RequestHandler.php(84): Laminas\Stratigility\MiddlewarePipe->process()
#44 /vendor/laminas/laminas-stratigility/src/Next.php(49): Middlewares\RequestHandler->process()
#45 /vendor/middlewares/base-path-router/src/BasePathRouter.php(99): Laminas\Stratigility\Next->handle()
#46 /vendor/laminas/laminas-stratigility/src/Next.php(49): Middlewares\BasePathRouter->process()
#47 /vendor/laminas/laminas-stratigility/src/Middleware/OriginalMessages.php(36): Laminas\Stratigility\Next->handle()
#48 /vendor/laminas/laminas-stratigility/src/Next.php(49): Laminas\Stratigility\Middleware\OriginalMessages->process()
#49 /vendor/middlewares/base-path/src/BasePath.php(73): Laminas\Stratigility\Next->handle()
#50 /vendor/laminas/laminas-stratigility/src/Next.php(49): Middlewares\BasePath->process()
#51 /vendor/flarum/core/src/Http/Middleware/ProcessIp.php(24): Laminas\Stratigility\Next->handle()
#52 /vendor/laminas/laminas-stratigility/src/Next.php(49): Flarum\Http\Middleware\ProcessIp->process()
#53 /vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(75): Laminas\Stratigility\Next->handle()
#54 /vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(64): Laminas\Stratigility\MiddlewarePipe->process()
#55 /vendor/laminas/laminas-httphandlerrunner/src/RequestHandlerRunner.php(73): Laminas\Stratigility\MiddlewarePipe->handle()
#56 /vendor/flarum/core/src/Http/Server.php(45): Laminas\HttpHandlerRunner\RequestHandlerRunner->run()
#57 /public/index.php(26): Flarum\Http\Server->listen()
#58 {main}

php flarum info

Flarum core: 1.8.11
PHP version: 8.0.26
MySQL version: 5.7.44-log
Loaded extensions: Core, date, libxml, openssl, pcre, sqlite3, zlib, bcmath, ctype, curl, dom, filter, ftp, gd, gettext, hash, iconv, intl, json, mbstring, SPL, session, pcntl, standard, PDO, mysqlnd, pdo_sqlite, Phar, posix, Reflection, pdo_mysql, shmop, SimpleXML, soap, sockets, sodium, mysqli, sysvsem, tokenizer, xml, xmlreader, xmlwriter, zip, fileinfo, exif, Zend OPcache
+--------------------------------------+----------+--------+
| Flarum Extensions                    |          |        |
+--------------------------------------+----------+--------+
| ID                                   | Version  | Commit |
+--------------------------------------+----------+--------+
| flarum-likes                         | v1.8.1   |        |
| flarum-tags                          | v1.8.5   |        |
| antoinefr-money                      | v1.4.0   |        |
| flarum-flags                         | v1.8.2   |        |
| flarum-mentions                      | v1.8.5   |        |
| xypp-store                           | v1.1.5   |        |
| flarum-sticky                        | v1.8.2   |        |
| afrux-forum-widgets-core             | v0.1.7   |        |
| flarum-suspend                       | v1.8.4   |        |
| v17development-seo                   | v2.0.9   |        |
| flarum-approval                      | v1.8.2   |        |
| xypp-user-decoration                 | v1.2.1   |        |
| xypp-sticky-card                     | v1.1.0   |        |
| the-turk-stickiest                   | 3.0.1    |        |
| sycho-advanced-extension-categories  | v0.1.3   |        |
| pipecraft-id-slug                    | v1.1.0   |        |
| nodeloc-my-emoji                     | dev-main |        |
| nodeloc-friend-link                  | 1.1      |        |
| mattoid-money-history-auto           | v1.10.2  |        |
| mattoid-money-history                | v1.1.3.2 |        |
| justoverclock-custom-html-widget     | 0.1.4    |        |
| imeepo-more-bbcode                   | v1.0.3   |        |
| huseyinfiliz-notificationhub         | v0.3     |        |
| foskym-custom-levels                 | v3.4.0   |        |
| fof-user-bio                         | 1.4.2    |        |
| fof-sitemap                          | 2.4.1    |        |
| fof-profile-image-crop               | 1.1.6    |        |
| fof-nightmode                        | 1.6.0    |        |
| fof-links                            | 1.4.0    |        |
| fof-linguist                         | 1.1.6    |        |
| fof-frontpage                        | 1.2.0    |        |
| fof-formatting                       | 1.1.0    |        |
| fof-default-user-preferences         | 1.2.1    |        |
| flarumtr-mobile-search               | v1.2     |        |
| flarum-subscriptions                 | v1.8.1   |        |
| flarum-statistics                    | v1.8.1   |        |
| flarum-pusher                        | v1.8.1   |        |
| flarum-nicknames                     | v1.8.2   |        |
| flarum-markdown                      | v1.8.1   |        |
| flarum-lock                          | v1.8.2   |        |
| flarum-lang-english                  | v1.8.0   |        |
| flarum-lang-chinese-simplified       | v1.6.0   |        |
| flarum-bbcode                        | v1.8.0   |        |
| ffans-geetest                        | v1.0.7   |        |
| dem13n-topic-starter-label           | 0.1.8    |        |
| datlechin-usercard-uid               | v0.1.1   |        |
| datlechin-scroll-buttons             | v1.1.0   |        |
| darkle-fancybox                      | 2.1.0    |        |
| clarkwinkelmann-money-rewards        | 1.0.0    |        |
| clarkwinkelmann-discussion-bookmarks | 2.0.1    |        |
| blomstra-usercard-stats              | 0.1.2    |        |
| afrux-news-widget                    | v0.1.1   |        |
| afrux-forum-stats-widget             | v0.1.1   |        |
| acpl-mobile-tab                      | 1.4.5    |        |
| acme-douban-movies                   | dev-main |        |
+--------------------------------------+----------+--------+
Base URL: 
Installation path: 
Queue driver: sync
Session driver: file
Scheduler status: 从未运行
Mail driver: mail
Debug mode: off

clarkwinkelmann

qishou this could indicate your PHP version is too low to run this extension.

The developer has not properly documented the minimum required PHP version in the extension metadata, and I don't see any mention of the PHP version requirement in the README.

Based on the code I see in AddDiscussionViewHandler, you probably need at the very least PHP 8.1 for the readonly property support.

EDIT: or alternatively, downgrade to version 7.3 of the extension, which doesn't seem to have any PHP 8+ code.

@MichaelBelgium something to take a look at. You need to add the PHP version requirement to composer.json, and/or consider rewriting the code to support older PHP versions.

MichaelBelgium

I released v7.4.2 which makes the extension compatible with php >=7.4 (unfortunately)

But please consider upgrading to at least php 8.2 @qishou as you're using a php version thats EOL. And with 8.2 you'll be set for flarum v2 also.

qishou

clarkwinkelmann Thank you for your help.

qishou

MichaelBelgium Thank you for resolving it.

« Previous Page