Discussion startPost() issue ?

niiicou

Hi,

In our extension we use the relation startPost() from discussion, but if we delete once and for all the first post of a discussion, we've got JS error ...

TypeError: discussion.startPost(...).id is not a function(…)

In fact, in the discussions table there's no change of the startPostId stored, so the relation is wrong..

Is that a bug of flarum core or did we do something wrong ?

Thanks

Edit: We use last beta release

luceos

niiicou the startPost is assumed to be always existent. If you delete the post with the id under start_post_id you break things. You either must set it to null or replace the id in the discussions table.

I'm not sure what I can suggest to meet your needs, because you haven't explained why you are deleting the startPost in the first place.

niiicou

I just deleted the first post in frontend like a normal post.

I was thinking that delete the whole topic but nope ..

luceos

niiicou okay now I'm confused. In your OP you mention your extension deletes the first Post of a Discussion which triggers that the relation startPost of Discussion is missing. Now you tell that you are deleting the first post from a discussion in the frontend.

If your extension is running the logic to delete the first post of a discussion, yes you have to take into consideration you also need to delete the related discussion if you wish to do so.

In a vanilla installation I haven't experienced the issue, so this can't be a support question, right?

_Abstr4ct

Hi @luceos. In a normal way, without speaking about any custom extension, flarum allows to moderators and andministrators the ability to delete the first post of a discussion.
So after deleting the first post, the others posts of the discussion are correctly displayed but in DB the start_post_id of the discussion still refer to the deleted post id.
Therefor the startPost relation is wrong.

@niiicou says that the issue is in flarum core

luceos

So I ran the following:

create discussion, delete discussion forever
create discussion, add reply post, delete discussion forever
create discussion, delete first post forever
create discussion, add reply post, delete first post forever

It all worked seamlessly. In case of the last test, the reply was moved to the top. I never received any errors.

_Abstr4ct

luceos Thank's for testing ?
In this case : "create discussion, add reply post, delete first post forever", what is the start_post_id value in discussion table after deleting first post ?

luceos

_Abstr4ct I have no clue, I tested here on these forums. You say that causes the error? How did you trigger the error?

_Abstr4ct

In front-end and on default flarum installation no error is fired.
but, if custom extension include startPost relation on ShowDiscussionController (ConfigureApiController Event) for example this cause issue because the start_post_id refer to a non-existant post

if ($event->isController(Controller\ShowDiscussionController::class)) {
   $event->addInclude('startPost');
}

niiicou

To complete,

The start_post_id field in the database is not updated if the first post is removed.

So we have a discussion, with start_post_id reffer to a post deleted.