built-in lightbox function

Justoverclock

i'm about to create some internal page for flarum.it and i've found an interesting (for me maybe) question.
i'm about to create an image gallery and i will also need a lightbox...

why flarum doesn't have this function built-in

or maybe there's some method to call other extension functions like phenomlab-fancybox? otherwise i need to implement a lightbox, and it will be loaded twice (phenomlab + my extension).

askvortsov

Justoverclock why flarum doesn't have this function built-in

Why would it? It's not currently used inside flarum, so there isn't a reason to include it in core. If we included every js library out there, our JS would be terabytes large

Justoverclock

askvortsov oh, maybe i'm wrong, but it usable for posted image..or not?

askvortsov

Justoverclock oh, maybe i'm wrong, but it usable for posted image..or not?

To clarify, I like the idea of a lightbox extension. Currently looking at posted images is quite inconvenient, especially on mobile.

In my comment I was just saying that we prefer not to put things in core unless they really need to be there. This feature hasn't been implemented for core (at least not yet). We do have open issues about optimizing how multiple extensions can both use the same library.

Justoverclock

askvortsov ok, in that case i need to call again a lightbox, or better as phenomlab says, we can update fancybox-wrapper to target that new extension also.

😃

[deleted]

askvortsov To clarify, I like the idea of a lightbox extension. Currently looking at posted images is quite inconvenient, especially on mobile.

Mine does this - phenomlab/fancybox-wrapper 🙂