Why when I search a word, selecting a specific tag (https://discuss.flarum.org/t/support?q=word), it shows All Discussions results?

I have to refresh in order to view the filtered results.

To reproduce it, do not click on the link above but follow the step-by-step way:

  1. Search a word
  2. Select a Tag (shows All Tags Discussions)
  3. Refresh the page (shows specific Tag Discussions)

This was caused by a recent refactor to our search system. I think there's a GH issue open for this, but can't find it right now.

    robinodds no not quite. Essentially, before the tag would get added as an implicit search param. Now tag pages use filtering, not searching, so that has no effect.

      13 days later

      robinodds I'm sure there were other issues, but now I can't find them... Yay!

      Anyways, a quick update. I've started looking into this, and have opened flarum/core2849. This includes some cleanup to the search state / search source system, but does not fix this particular issue. I've been trying to replicate the old behavior as I remembered it (searching while on a tag page shows results from that tag page, in that tag page). But I haven't been able to do that. The closest I've gotten while looking for old forums with the old behavior is that previously, going to a tag page while there's an input restricts the search to that tag.

      That being said, I think the behavior I imagined makes sense (kinda like reddit: if you search while in a subreddit, it shows you results from that subreddit). However, it needs a fair bit of planning and discussion beforehand, so it will likely happen over the course of the 1.x releases.

          askvortsov searching while on a tag page shows results from that tag page, in that tag page

          I can confirm this behavior does not happen on beta.13.

          askvortsov I think the behavior I imagined makes sense

          For what it's worth, I agree.

              I wrote up a GH issue at flarum/core2850. A lot of it is technical / implementation ramblings, but suggestions on improvements to the search UI are always appreciated.

              One thing that should have its own issue is a UI for gambits (searching by author, tag, etc): I'm envisioning something similar to Discord, but it would need a fair bit of planning.