LESS style added by extension not applied

alexbnc

I am trying to replace a component with something that I have in mind but I have problem with the LESS file. The component's view is created but the style is not applied. I am doing this in my local repository, as described by @luceos here: https://discuss.flarum.org/d/1608-extension-development-using-composer-repositories-path

So, I have added the less/forum/extension.less in my extension's folder and some styling stuff for the new elements. I add the asset to the listener:

$event->addAssets(
    __DIR__.'/../../js/forum/dist/extension.js',
    __DIR__.'/../../less/forum/extension.less'
);

and I have the scripts/compile.sh file, which I run before enabling the extension. I also removed the generated .CSS from the public assets folder but the style is just not applied.

I feel like I am missing something

luceos

alexbnc there is no need to run the compile.sh, no idea where that was mentioned. When an extension is enabled Flarum will find the asset because:

the bootstrap.php in your extension is called, which has
an event listener, which adds the assets, so
Flarum will add those assets in compilation for JS and Less.

So verify you have a bootstrap.php that adds the event listening in the first place. You an verify whethet that works by simply adding a var_dump('foo');exit; above the addAssets call in your listener.

jordanjay29

The style works when you apply it otherwise (in web developer or via Flarum's admin custom CSS field)?

alexbnc

jordanjay29 yes, it does when applied via admin's custom CSS

jordanjay29

Have you Disabled and Enabled the extension since applying the less file? Flarum won't refresh its cached extension files until you do.

alexbnc

jordanjay29 I delete the CSS files from public/assets and they are re-created

Davis

luceos there is a compile.sh in the flarum extensions. It confused me when I started writing extensions too. He likely copied it over thinking it was required.

alexbnc

luceos Davis, like I said, the JS is added. Only the LESS file is not. Yeah, using the compile.sh was just an act of, let's say, desperation. It didn't make sense to me either but, well, coding involves magic and luck sometimes (not this time ?).
Anyway, this is how I add them:

$events->listen(ConfigureClientView::class, function (ConfigureClientView $event) {
        if ($event->isForum()) {
            $event->addAssets(
                __DIR__.'/../../js/forum/dist/extension.js',
                __DIR__.'/../../less/forum/extension.less'
            );
            $event->addBootstrapper('alexbnc/customtabs/main');
        }
    });

I delete the .css file in the public/assets folder, it is regenerated but none of my extension's properties are added

alexbnc

Square brackets were missing. This is why I prefer:

$event->addAssets(
    [
        __DIR__.'/../../js/forum/dist/extension.js',
        __DIR__.'/../../less/forum/extension.less'
    ]
);

jordanjay29

Working now?

alexbnc

jordanjay29 yes, thanks