Correct url transliteration with any language

Believer

Hello ? As i see, your transliteration function dont know about other languages and dont can make correct url for its.

For example, urls for posts with cyrillic names in our installed forum has urls like this: http://our-website/d/9--

For make always correct urls you can use PHP Intl Transliterator extension.

For example, you can use this snippet of code for transliterate any strings to latin characters (even japanese characters, as I know)

$str = 'Какая-то строка, которая нуждается в транслитерации';
$stransliteratedStr = transliterator_transliterate('Any-Latin; Latin-ASCII; [\u0080-\uffff] remove',$str);
// Kakaa-to stroka, kotoraa nuzdaetsa v transliteracii

I think, it can make you forum more convenient for people who speak other languages.

You can find more info about this transliterator functions in sources of Yii 2 framework, for example.

Believer

You can change you slug generating code to this:


    /**
     * Create a slug out of the given string.
     *
     * Non-alphanumeric characters are converted to hyphens.
     *
     * @param string $str
     * @return string
     */
    public static function slug($str)
    {
        $str = transliterator_transliterate('Any-Latin; Latin-ASCII; [\u0080-\uffff] remove', $str);
        $str = strtolower($str);
        $str = preg_replace('/[^a-z0-9]/i', '-', $str);
        $str = preg_replace('/-+/', '-', $str);
        $str = preg_replace('/-$|^-/', '', $str);

        return $str ?: '-';
    }

And post names will be correctly transliterated ?

7h3ev1l

Believer Unbelievable!!! Thanks!! I waiting so long for this fix. I applied it and its working perfect.

sanwhere

Believer what about for old topic's slugs?
i have 21000 recorded slugs, and i donnow how to make them correct. is there any query for database?

jordanjay29

Hi @Believer! I see you joined us in September but didn't actually post until today. So welcome!

These are good suggestions. Have you glanced at the discussion on the issue over at Github?

If you're interested in contributing, we'd love to have you write a Pull Request for your suggested changes, since you seem to be mostly there. Or you could write it as an extension for Flarum. I know plenty of people have been asking about this, so it would definitely be useful for Flarum.

Believer

jordanjay29 i interested in contributing ? Thanks for link on issue, i created message with this idea.