quick edit extension

Justoverclock

This could be a useful extension i think, i've no idea how is implemented but i think someone here can find this interesting...

fast edit:

clarkwinkelmann

Justoverclock interesting feature.

I'm not sure how (that's Discourse?) stores their formatted post internally, but the challenge would be mapping a selection coordinate from the formatted post into a selection coordinate on the source post. Then it's "just" a little modal and a call to the existing edit API.

I wonder how it looks like if you edit across some bbcode or markdown tags? I assume it just shows the raw source without any formatting button?

askvortsov

Justoverclock It's a great idea and feature. The challenge is mapping positions in text to positions in the markdown. I suppose a starter algorithm could work by processing some buffer text around the sides.

Justoverclock

clarkwinkelmann I'm not sure how (that's Discourse?)

yes it is

matteocontrini

The feature should be called "fast edit" and it seem to be implemented with a JavaScript replace() call on the raw content: https://github.com/discourse/discourse/blob/c599469e9de420336117133a9dcadb68f53679fb/app/assets/javascripts/discourse/app/components/quote-button.js#L409-L412

And this is where the selected text is saved in _fastEditInitalSelection: https://github.com/discourse/discourse/blob/c599469e9de420336117133a9dcadb68f53679fb/app/assets/javascripts/discourse/app/components/quote-button.js#L71

Not sure how that works with formatting... 🤔

Braden

That is going to be a gold extension, great idea 👍️

010101

Fancy. Would it be worth it I wonder? Or add unnecessary code bloat to your forum? Tapping edit is pretty quick already. I guess this saves a second or two? And, it’s cool. The coolness factor alone could be worth it. 😎

Justoverclock

010101 well, i see this extension as a potential replace of the edit button to be honest.
they have also a really cool feauture for guest, is basically the same but instead of editing, guest can share the selected text or send it through mail.

askvortsov

Justoverclock I think both have their role. You'd still be able to edit the whole post, but also being able to quick edit small parts.

matteocontrini

Genius.com has a similar feature if I'm not mistaken.

Justoverclock

matteocontrini exact and is also an engagement for signup

matteocontrini

Justoverclock this is how it looks when signed in:

010101

Justoverclock also an engagement for signup

Ok. That’s really nice.

It would fit in well with Flarum. Because already when you highlight you have the quote tooltip. That could instead turn into “quote | edit” or something like that.

And many times all you want to do is fix one small mistake. I suppose it would be better than fully editing the post.

But, you shouldn’t tease us with cool potential features like this. Now I want it but can’t have it. 😂

Justoverclock

010101 lol, this is material for real developers 😅