Is there a character limitation in custom CSS?

Darkle

I've updated a couple of things in the CSS and I've reached 1849 lines, normally what I do is a ctrl+a from VS Code and copy and paste it into the Flarum CSS from the admin panel, but this time I got an error and I checked it with the debugger, it was a ParseError: missing closing}``.

It didn't make much sense so when I checked it I realised that the problem is that when saving the CSS the last lines are cut hence the missing } among other things.

Is this something done on purpose? or should I open a issue in the flarum/core?

clarkwinkelmann

Darkle it's probably not the number of lines, but rather the number of characters or bytes.

Settings have a maximum value size (MySQL TEXT column) and I suspect the code gets truncated.

I assume your error is when accessing the forum and not when saving? We have a step to validate the Less but the code probably gets truncated when inserted in the database, so the validation won't catch it https://github.com/flarum/core/blob/master/src/Forum/ValidateCustomLess.php

We should probably add max length validation for all settings. This probably has never been an issue in the past because most settings are short strings and there was never any risk of reaching the TEXT limitation.

Darkle

clarkwinkelmann I assume your error is when accessing the forum and not when saving?

Exactly, only when accessing the forum.

I've posted the issue on GitHub here, in case you might want to add something else, thanks!