MikeJones Same thing as before, it rolls back all migrations
Dev Diary: Build 19
MikeJones askvortsov ...which in practice means removing the extension data from the database
askvortsov 2. Support setting nicknames on registration
This is a simple but great UX change, we've had a few users asking, for example, why they can't have spaces in a name, when they can see that other people have them. A lot of people won't go to their profile and notice the ability to change nickname, so this makes a lot of sense.
Just another very quick update from myself.
My PHPStan progress continues forward, it's taking more time than I had hoped but regardless I am making good progress so I'm happy with that. Especially given I started with 300+ errors and now I'm down to about 120 errors, of which it's related to solving issues with understanding Eloquent magic properties and methods in Models.
- Edited
Another quick update for flarum/mentions, bumping it to v1.1.3.
Added
- chore: add missing compat exports and extensibility by @gianniguida in flarum/mentions76
Fixed
- fix: errors on texteditor re-use again by @davwheat in flarum/mentions78
- fix: allow mentions from non-post objects by @IanM in flarum/mentions79
Full Changelog: https://github.com/flarum/mentions/compare/v1.1.2...v1.1.3
This release fixes an incompatibility which prevented the use of mentions in some third-party extensions, such as FoF Moderator Notes and FoF Pages. If you use extensions which need mentions in any location outside of posts, you should update to v1.1.3.
I think remaking MOBILE THEME is very very good idea for Flarum :/
HasanMerkit this great feature!
Another update from me... We're making progress with PHPStan! It's taken a ton of time but with a little help from @askvortsov yesterday for a bit we were able to wipe out a bunch of issues (and create some new ones), once I get the newest big issue with it squared away I'll push to git so everyone can see the progress.
HasanMerkit On the mobile view side, I think they need to interfere with the admin panel. Especially to the permissions page
- Edited
Hey everyone! I'm excited to announce that we are now in the QA stage for our v1.2 release. As part of our QA process, we have updated Discuss to the dev versions of core and all bundled extensions. Please report any new issues you experience here, so we can make this release as great as possible. Thank you!
iPhone, I go to input my credentials to log in. I tap the username field, it does not let me select it. I have to submit the blank form once, which of course results in an error. Only then can I input my credentials.
I must confess I haven't been involved with core development as much as I hoped I would. Regardless I am happy that 1.2 is around the corner
I am hoping that everyone will be able to step away from screens, by spending time with your loved ones and hugging those exempt from being social distanced to.
Be safe, stay healthy and above all enjoy the holidays
- Edited
askvortsov Please report any new issues you experience here
I noticed that text is not converted to a link automatically in older posts, e.g. https://discuss.flarum.org/d/21894-friendsofflarum-best-answer/203
It only works in new posts as you can see. In old ones it worked before.
- Edited
luceos Reenabled, should be good now!
010101 iPhone, I go to input my credentials to log in. I tap the username field, it does not let me select it. I have to submit the blank form once, which of course results in an error. Only then can I input my credentials.
That's wacky, we'll take a look. Thanks!
Might just be me but URLs aren’t updating. I searched for something, then I noticed as I went from discussion to discussion the address bar URL didn’t change.
Search results on Firefox can be unreadable when search terms contains letters like "g".
It is not new, is an old and unfixed bug....
Zeokat I'm unable to replicate this. What version of firefox are you using?
010101 Might just be me but URLs aren’t updating. I searched for something, then I noticed as I went from discussion to discussion the address bar URL didn’t change.
Are you getting this consistently? If so, what device/browser, and how are you navigating between discussions?
askvortsov iPhone, I go to input my credentials to log in. I tap the username field, it does not let me select it. I have to submit the blank form once, which of course results in an error. Only then can I input my credentials.
Found, tracked down the problem. Should have a fix out soon.
- Edited
askvortsov Are you getting this consistently? If so, what device/browser, and how are you navigating between discussions?
Can’t replicate it now. It was in Firefox on my iPhone. It’s funny, most of the time when random weird things happen, it’s on an iPhone.
Here’s a new one. No number of posts showing next to the word association topic. But, after going into the topic and returning to the home page, the number appeared. And once I marked it as read it was fine.
- Edited
@luceos @askvortsov I'm using FireFox Desktop 95.0.2 (64-bit) (latest version) under Windows 10 21H1.
Also the bug tested under other PCs with FireFox.
I'm pretty sure the bug exists, because i can replicate it on every Flarum community that i tested. The bug is not easy to detect, because it always shows into the third search result, it have to be bold and it has to be a letter that takes up space downwards like g, p, j, etc ...
@davwheat If you take a view slowly into the image posted you will find the problem, it should be self explanatory.
Not sure if related, but Chrome on my Android phone freezes after opening this post. Everything is fine on Firefox.
- Edited
hrvoje_hr it should be related to the code block: https://discuss.flarum.org/d/29640-chrome-android-freezing-when-opening-a-specific-discussion
Was soft delete permissions turned off here or is this a new bug? I've tried to delete a post of mine, but it comes right back.
010101 fixed by @askvortsov in flarum/core3249
Hey everyone, wanted to share some quick updates on our end.
We're still in the QA process, mostly due to the massive size of the release, the holiday season, and our upcoming process changes. Mostly, we've been:
- Fixing bugs discovered during the QA phase, as well as finding new ones
- Cleaning up and standardizing some parts of our codebase across extensions. Thanks to @IanM for playing a leading role in this effort!
- Preparing for the move to a monorepo for all core and bundled extension development. This will make it much easier for us to keep track of ongoing work, and crucially, allow for tighter CI integration that should reduce accidental breaking changes / issues.
- Refactoring / expanding Flarum CLI. After over 100 commits, among many other improvements, it now supports:
- Adding TypeScript, Prettier, GitHub Actions, and a lot of other functionality to an extension via a single command:
flarum infra MODULE
- Making sure all this infrastructure is up to date via
flarum audit infra
- Developing in Flarum Core, and in Flarum monorepos
- A no-interaction mode, so you can include flarum CLI commands in automated scripts
- Adding TypeScript, Prettier, GitHub Actions, and a lot of other functionality to an extension via a single command:
Thank you to everyone who has been reporting issues here on Discuss! We've updated core to the latest changes which should fix most of the above issues, except for the chrome android code highlighting one, which will probably need to wait till the next release since it's not a new one.
- Edited
I've found a bug, I think it's new, I don't remember it happening before, the gif is quite explanatory:
- Enter a discussion
- Search for a discussion (it seems not a random one, it happened to me at least with the Direct Links discussion)
- Return to the previous one
The discussion disappears and also the internal links stop working (click on the logo, for example)
Update:
If the start discussion is long it seems to have a different behaviour.
I get a console error as soon as I search and enter the discussion and the rest when I try to go back.
Darkle Looks like some cleanup ended up introducing new bugs. We'll investigate, and try to adjust our processes to avoid this repeating in the future.
Darkle Should be fixed now, or at least I can't replicate anymore. Could you check if you still encounter this?
askvortsov Both cases no longer happen, fixed!