V1.2 bug report

askvortsov

mekici I'm not seeing this locally: when I try to put color config that doesn't compile, I get an error while trying to save due to the LESS validation. Are you able to replicate on nightly?

Ralkage

askvortsov not reproducible in nightly or the demo site 🤔

mekici curious, did you manually edit the value of theme_primary_color directly in the DB?

mekici

Ralkage i can reproduce this in both production forum and local install.

I fixed the color code manually from the database.

mekici

askvortsov Can you press the save button when you get an error?

Justoverclock

i can reproduce this on my local install also...its a bug

askvortsov

Justoverclock Could you record a video? For me, when I try to save invalid values, there's an error message, and when I refresh the page, I see that the old values are still there.

clarkwinkelmann

Do you have or had had Nightmode installed?

I believe it breaks this because it overrides the ValidateCustomLess file with a version that isn't compatible with Flarum 1.2.

You might need to delete the vendor folder and run composer install to recover the original file version if disabling Nightmode and updating isn't enough.

EDIT: opened issue FriendsOfFlarum/nightmode56

Umutcan

askvortsov Do not refresh, press the save button.

mekici

clarkwinkelmann In my local installation, the night mod extension is installed but never activated. Night mode plugin is active on production forums.

The situation I mentioned in both the teaching forums and local installation is valid.

clarkwinkelmann

mekici the way Nightmode is implemented, it doesn't matter if it's enabled or not, because it uses a Composer feature to override code in Flarum as soon as the package is installed.

mekici

clarkwinkelmann 👍

Justoverclock

@askvortsov sure I will do this when I’m back on pc.

P.s. I have night mode installed

I think Clark found the issue

datitisev

I have made a PR to fix this (FriendsOfFlarum/nightmode57), among other issues (frontend conflicts, hopefully fixes e.g. embed & wordpress ext issues).