Country Flags

adbo

@Justoverclock still maintaining this? There's a bug if you select a country and then select the option "Click to select your country", it thinks that option is a valid country so tries to render a flag from https://purecatamphetamine.github.io/country-flag-icons/3x2/Click%20to%20select%20your%20country.svg

Justoverclock

try now with 1.0.0 @adbo

adbo

Justoverclock
Thanks for the quick reply. Updating doesn't seem to have changed anything in my test environment unfortunately. Ran composer update which updated 0.2.1 => 1.0.0, migrate and cache:clear. Tried disabling and re-enabling the extension too.

With United Kingdom selected:

With Click to select your country selected:

Justoverclock

adbo mmmhh I will take another look. I was pretty sure that was fixed!

Litalino

Justoverclock
My Fixer:

Search line if (countryFlag === '') return; add after if (countryFlag === undefined) return

if (countryFlag === '') return;
if (countryFlag === undefined) return;  //Add Line

Gorm

Justoverclock can you confirm "updated" version of Country Flags? Or its just a fork which do replacement of original extension (why?)? Is upgrade recommended or not (seems it will have conflict with newer version of originall Country Flags)?

« Previous Page