Link Preview

ernestdefoe

naxvog So that's good to know it's nothing wrong with my setup. It's even doing it for the Flarum site as well. Made a test post just to test out another site.

naxvog

ernestdefoe Tested the DNS issue further.
Might be that the server's DNS cache needs to get primed for this to work reliably. Subsequent requests seconds after the first one returned the expected result.
Tested with flarum.org and community.flarum.org. The second one failed the DNS test for the first 10 seconds or so but after that it worked like a charm. Keep in mind that I tested using a docker container most likely running a local network primed DNS 😉

ernestdefoe

naxvog Well I don't see me posting a ton of links but it would be nice for it to work right for when I do but it's no huge rush to figure out the cause of it. I'm sure others may feel different about that though.

ernestdefoe

Any update on a fix? Just curious.

datlechin

ernestdefoe you can rollback to the v1.1.2 until we have an update for your issue

naxvog

ernestdefoe Bear in mind that the gethostbyname problem will exist in prior versions too as it was introduced in v0.1.7

Dr_Sommer

DId an update to v1.2.2 and now there are no Preview images no more (no LINK-IMAGE Div!)

https://ibb.co/dMyVgGH

I removed Link Preview entirely and reinstalled it, still no preview image...
Did I do something wrong? I`m new to Flarum.. 😆

datlechin

Dr_Sommer go to Link Preview extension, active the Use Google Favicon API option

Dr_Sommer

Argh.. how stupid.. 😆
Thank You, datlechin... 👍️

jslirola

@datlechin is it possible to whitelist a domain that includes a path? e.g:

mydomain.com/profile/

In theory this case is valid, at least according to the text that will appear in the white list field before writing anything, but it doesn't work for me. The only way I have found to show previews is with the domain only without paths.

Thank you.

naxvog

jslirola this is indeed not supported at the moment. Might create a merge request to fix this issue in the coming days.

jslirola

naxvog Great, let me know here or Discord if you need me to run some tests at any point

naxvog

PR created datlechin/flarum-link-preview19
Feel free to test @jslirola

jslirola

naxvog It runs smoothly, thank you!

datlechin

V1.2.3

What's Changed

Fix: Display found preview image while not using the Google favicon API by @naxvog in datlechin/flarum-link-preview16
Fix link attributes by @naxvog in datlechin/flarum-link-preview17
Additional changes to the preview image by @naxvog in datlechin/flarum-link-preview18
Default settings + Simple Link Globbing by @naxvog in datlechin/flarum-link-preview19

Full Changelog: https://github.com/datlechin/flarum-link-preview/compare/v1.2.2...v1.2.3

datlechin

V1.3.0

What's Changed

Various changes by @naxvog in datlechin/flarum-link-preview20
- LoadingIndicator component usage to improve the look and feel
- Loading class for the component wrapper
- Icon component to improve accessibility
- Preview generation on refreshContent to include post updates as well (triggers right after a post was edited without a page refresh)

Full Changelog: https://github.com/datlechin/flarum-link-preview/compare/v1.2.3...v1.3.0

Subarist

datlechin
V 1.3.0

If you edit an existing article.
After modifying the link, click Preview. Preview generation will loop infinitely.
Then , flarum will continuously report errors.
until I click exit.

datlechin

Subarist
Can i get your php flarum info, and try to run php flarum cache:clear if it solves your problem

Currently, in Editing mode, the content will show the raw link, if Link Preview generating while you editing the post, it might have problems.

Lumeinshin

datlechin I tried to recreate Subarist 's issue, I was surprised to see that it wouldnt generate the preview until editing was finished. so +1 on making sure to clear cache and fully refresh the page before trying to edit if you havent already

Subarist

datlechin
cache:clear -- checked
Flarum core 1.6.3 PHP version: 8.2.0 MySQL version: 8.0.32 Loaded extensions: Core, date, libxml, openssl, pcre, sqlite3, zlib, bcmath, ctype, curl, dom, filter, ftp, gd, gettext, hash, iconv, intl, json, mbstring, SPL, session, pcntl, standard, mysqlnd, PDO, pdo_mysql, pdo_sqlite, Phar, posix, random, Reflection, mysqli, shmop, SimpleXML, soap, sockets, sodium, sysvsem, tokenizer, xml, xmlreader, xmlwriter, zip, fileinfo, exif, gmp, redis, memcached +-------------------------------------+--------------+--------+ | Flarum Extensions | | | +-------------------------------------+--------------+--------+ | ID | Version | Commit | +-------------------------------------+--------------+--------+ | flarum-markdown | v1.6.1 | | | flarum-flags | v1.6.1 | | | flarum-suspend | v1.6.1 | | | askvortsov-rich-text | v2.1.7 | | | flarum-tags | v1.6.1 | | | flarum-lock | v1.6.1 | | | fof-formatting | 1.0.2 | | | afrux-forum-widgets-core | v0.1.7 | | | flarum-nicknames | v1.6.1 | | | fof-spamblock | 1.1.0 | | | fof-pages | 1.0.4 | | | flarum-approval | v1.6.1 | | | sycho-advanced-extension-categories | v0.1.3 | | | v17development-seo | v1.8.0 | | | v17development-blog | v0.6.4 | | | sycho-profile-cover | v1.3.3 | | | rob006-last-post-avatar | 1.1.0 | | | pipecraft-id-slug | v1.1.0 | | | nearata-tags-color-generator | v2.2.0 | | | malago-fancybox | 0.3.0 | | | justoverclock-hashtag | 1.0.1 | | | justoverclock-geo-weather | 0.1.7 | | | justoverclock-custom-html-widget | 0.1.4 | | | justoverclock-country-flags | 0.2.1 | | | justoverclock-contactme | 0.2.3 | | | ianm-html-head | 1.1.0 | | | fof-username-request | 1.1.0 | | | fof-user-directory | 1.2.3 | | | fof-user-bio | 1.1.1 | | | fof-upload | 1.3.0-beta.1 | | | fof-stopforumspam | 1.2.3 | | | fof-socialprofile | 1.1.4 | | | fof-sitemap | 2.0.1 | | | fof-share-social | 1.1.2 | | | fof-profile-image-crop | 1.1.1 | | | fof-pretty-mail | 1.1.1 | | | fof-oauth | 1.3.0 | | | fof-nightmode | 1.5.1 | | | fof-merge-discussions | 1.3.1 | | | fof-links | 1.1.3 | | | fof-drafts | 1.2.2 | | | fof-default-user-preferences | 1.2.0 | | | fof-best-answer | 1.2.4 | | | fof-analytics | 1.1.0 | | | flarumtr-mobile-search | v1.2 | | | flarum-subscriptions | v1.6.3 | | | flarum-sticky | v1.6.1 | | | flarum-statistics | v1.6.1 | | | flarum-mentions | v1.6.3 | | | flarum-likes | v1.6.1 | | | flarum-lang-english | v1.6.0 | | | flarum-lang-chinese-traditional | v1.6.0 | | | flarum-lang-chinese-simplified | v1.3.0 | | | flarum-emoji | v1.6.1 | | | flarum-bbcode | v1.6.0 | | | extiverse-mercury | 0.2.0 | | | davwheat-ads | 1.2.0 | | | datlechin-scroll-buttons | v1.1.0 | | | datlechin-posted-on | v0.1.6 | | | datlechin-link-preview | v1.3.0 | | | datitisev-post-galleries | 1.0.0 | | | clarkwinkelmann-scout | 0.3.3 | | | clarkwinkelmann-first-post-approval | 1.0.1 | | | clarkwinkelmann-emojionearea | 1.0.0 | | | clarkwinkelmann-author-change | 1.0.3 | | | blomstra-turnstile | 0.1.2 | | | blomstra-spam-prevention | 1.3 | | | blomstra-fontawesome | 0.1.5 | | | askvortsov-pwa | v3.1.3 | | | askvortsov-markdown-tables | v1.2.1 | | | afrux-online-users-widget | v0.1.6 | | | afrux-forum-stats-widget | v0.1.1 | | | afrux-asirem | v0.1.7 | | | acpl-mobile-tab | 1.1.1 | | +-------------------------------------+--------------+--------+

Subarist

datlechin
Same on the mobile.
Edit --> Modify--> Preview
then it happens
Film

naxvog

Subarist Will try to reproduce the reported error by installing all of your extensions one by one on my dev installation. Might need some time to get around to do that though.
In the meantime feel free to downgrade to ^1.2

edit: seems v17development-seo is causing the issue

« Previous Page Next Page »