Can't log in

010101

I can't log into my forum. I updated many extensions the other day so it is hard to say what happened. Here's the error causing no one to be able to log into my forum:

[19-Feb-2022 14:47:29 UTC] PHP Deprecated:  Required parameter $lastEditedBy follows optional parameter $settings in /vendor/askvortsov/flarum-auto-moderator/src/Action/ActivateEmail.php on line 30
[19-Feb-2022 14:47:29 UTC] PHP Fatal error:  Uncaught Laminas\HttpHandlerRunner\Exception\EmitterException: Unable to emit response; headers already sent in /vendor/laminas/laminas-httphandlerrunner/src/Exception/EmitterException.php:19
Stack trace:
#0 /vendor/laminas/laminas-httphandlerrunner/src/Emitter/SapiEmitterTrait.php(36): Laminas\HttpHandlerRunner\Exception\EmitterException::forHeadersSent()
#1 /vendor/laminas/laminas-httphandlerrunner/src/Emitter/SapiEmitter.php(27): Laminas\HttpHandlerRunner\Emitter\SapiEmitter->assertNoPreviousOutput()
#2 /vendor/laminas/laminas-httphandlerrunner/src/RequestHandlerRunner.php(98): Laminas\HttpHandlerRunner\Emitter\SapiEmitter->emit(Object(Laminas\Diactoros\Response\JsonResponse))
#3 /vendor/flarum/core/src/Http/Server.php(44): Laminas\HttpHandlerRunner\RequestHandlerRunner->run()
#4 /index.php(26): Flarum\Http\Server->listen()
#5 {main}
  thrown in /vendor/laminas/laminas-httphandlerrunner/src/Exception/EmitterException.php on line 19

Help?

010101

Even though the PHP error stated this, at first I did not believe it was the auto moderator. I thought that was just a warning. But, it is the auto moderator. I removed this extension and I can log in again. Maybe this happened because I increased my PHP version to 8.0.16. Not sure.

FYI @askvortsov

Edit: Oh... it's known. Ok. It's interesting that I just experienced this for the first time. Maybe because my forum has very little activity. askvortsov1/flarum-auto-moderator6

010101

New note around all of this for @v17development. I installed a version of auto moderator with the fixes in the above mentioned pull request. But then, my site won't load due to similar errors involving the user badges extension.

clarkwinkelmann

You should be able to set display_errors to Off in your php.ini to hide the Deprecated warning. This will restore access to the website.

This is likely caused by a change of PHP version which brings new deprecation warnings. It could also be an extension update that brought new code that causes PHP warnings/deprecations. As long as you configure PHP to ignore those warnings, everything should work fine.

010101

clarkwinkelmann There was a PHP Fatal error too though. If I turn off notices, there would still be something that wouldn’t work, right? Since a fatal error is also involved. I think it’s the fatal error which caused the log in to stop working for all users at my forum.

And yes, this all started because I went from PHP 7.4 to PHP 8. I don’t want to downgrade at this point so I’ll go without the extensions causing the problem and reinstall them if they are updated in the future.

Sadly, it’s an ongoing battle no matter what web software you use. Forum/CMS… you update PHP, then extensions/plugins no longer work. 😅

I’m used to it on one hand, on the other hand after 17 years of running websites, I get exhausted by things breaking after new PHP versions.

Maybe one day the PHP core devs can find a way to break less things when new versions are released. 🌈 That’ll be the day.

clarkwinkelmann

010101 the fatal error is that Flarum cannot continue sending the response because PHP intercepted the response to send its warning. If the warning is hidden, Flarum can continue rendering the page.

To be more technical, the actual error says Unable to emit response; headers already sent. That's because in PHP you need to first return the headers of the page, and only afterwards can you send the response body. When PHP starts writing its warning to the page body, Flarum has not sent its response headers yet. When the code finally reaches the point where headers are sent, the code crashes because Flarum doesn't expect anything to have been written to the page yet.

That's why display_errors should generally be disabled in production, it's a very messy way of outputting errors in a way applications can't control/react to.

The same error also happens if you add a newline at the top of any PHP files before <?php. It messes up with the "headers, then body" order.

010101

clarkwinkelmann That makes sense.

In this case, originally, the site was loading fine. There were no visible PHP warnings/errors. I just couldn’t log in. I only found out by checking my PHP error log.

Still, maybe what you’re suggesting would fix it. I know if I went extreme and told PHP to completely ignore warnings and errors it would work. But, I don’t want to go that extreme.

I will try what you’re suggesting.

010101

clarkwinkelmann Didn’t work. But, thank you for reminding me to turn display errors off. That will help with future issues. For this though it doesn’t help.

There’s no traditional PHP warnings visible, this happens:

Auto moderator extension and probably the user badges extension I use both need an update.

Relic System

010101 Auto moderator extension and probably the user badges extension I use both need an update.

not helpful information but information nonetheless - I've been running Flarum 1.2 with PHP 8.1 (I know, not supported) with badges 1.0.0 and auto moderator 0.1.2 and so far no massive issues at all.