Extending/removing BBcode not working anymore

MichaelBelgium

So I've stumbled on an issue but I'm not sure if it's something on my side or it's an actual bug.

In my MyBB to Flarum extension i replace the [size] tag but it does not seem to work. By replacing I mean remove the original and then add custom one, with the same name

As you can see here. I have these lines since the beginning of the extension and I'm sure it worked then (around beta 6 or 7) but now it does not anymore - noticed after testing.

This is the result:

After some dirty debugging I noticed the default SIZE tag is ALWAYS applied, delete and addcustom does nothing

Can anyone reproduce this issue?

clarkwinkelmann

Paging @JoshyPHP who might know if something changed with the TextFormatter API.

On Discord we discussed a variety of test but everything seems to point to the code correctly being called, just having no effect.

JoshyPHP

No, there's been no change in anything relevant. The BBCode works in isolation too.

$configurator = new s9e\TextFormatter\Configurator;
$configurator->BBCodes->addCustom(
	'[size={CHOICE=large,small,xx-small,x-small,medium,x-large,xx-large}]{TEXT}[/size]',
	'<span style="font-size:{CHOICE}">{TEXT}</span>'
);
extract($configurator->finalize());

$text = '[size=small]..[/size]';
$xml  = $parser->parse($text);
$html = $renderer->render($xml);

die("$html\n");

<span style="font-size:small">..</span>

MichaelBelgium

If i do a var_dump($config->BBCodes->collection); It's empty initially?

and var_dump($config->BBCodes->exists('size')); returns false

EDIT: ok after the $config->BBCodes->addCustom it does return true so doing $config->BBCodes->delete('size'); is pointless here? It still uses the SIZE template from the repository xml file though

JoshyPHP

You don't have to delete something that you want to overwrite. I don't think it makes a difference.

Deleting a BBCode will not remove the tag it maps to. You can remove the [URL] BBCode and still use URL tags via Markdown or other plugins.

MichaelBelgium

So it's possible that it conflicts with flarum/bbcode ?

If my extension gets loaded first, before flarum/bbcode - the size tag is overwriting my overwrite?
So it would be a matter of enabling my extension or flarum/bbcode - but both is not possible

JoshyPHP

I don't know any of that. That's something that needs to be debugged in situ. Otherwise, yes, if an extension defines a BBCode and another extension overwrites it, it is overwritten.