Rich Embeds

clarkwinkelmann

CyberGene oh, I see, it's an image tag inside of a link tag.

There's currently no special logic to handle that situation, so it should result in both a popover for the link and an overlay for the image.

I suspect the image overlay (and dimensions) fails to render because the two are nested. If it worked before I'm not sure what would have broken it but I will investigate.

I checked on the page you linked and all the metadata about the images is correctly loaded, so it's not a problem with Amazon. The problem must be in my extension's javascript.

CyberGene

clarkwinkelmann there's something intermittent, see this sandbox discussion for example:
https://pianoclack.com/forum/d/292-test-sandbox-discussion/28

Look at the last two posts, the first one is a just an URL to the image (on Wikipedia), the second one is the IMG inside URL (this is the same image but uploaded through FoF to our AWS). Sometimes I see the dimension overlays on both of them, then I don't see them on either one... I'm not sure what it depends on. Could also be a browser issue, who knows. I used to see those overlays, then I reloaded the page and can't see them anymore. I guess if I open the forum after a while they might be there again.

clarkwinkelmann

Version 1.2.1 - July 25, 2022

Fixed Rich Images wrapped in links not rendering correctly.
Fixed Alt text missing from Rich Images.
Fixed MySQL version check not comparing the correct numbers.

You must clear the Flarum cache for the alt text fix to be applied.

See 1.2.0 release notes if you are upgrading from an older version.

CyberGene this should fix the issues.

CyberGene

Thank you very much, that was fast 👏🏻

CyberGene

Yes, it’s fixed, thanks a lot for your efforts, this extension is great 🙂

P.S. do I have to execute the scan command again?

clarkwinkelmann

CyberGene no, running the scan again should not make any difference. It was all caused by the final rendering code.

clarkwinkelmann

Version 1.2.2 - July 26, 2022

Added Ability to store the full Google JSON authentication payload in the setting instead of the file path.
Fixed Composer requirements incorrectly allowing Guzzle 6. Only Guzzle 7 is supported.

See 1.2.0 release notes if you are upgrading from an older version.

GreXXL

I do have a bit of a layout issue. I tried to embed this link https://www.nutricia-metabolics.de/produkte/eiweissarme-lebensmittel/ and it resulted in about 40 images being displayed. Is there anything I can do about it. I though it's meant to just render one image within the box. This ways it breaks the site of course 😮 Thanks for the help!

luceos

GreXXL 40 images being displayed

You hit the jackpot! 😬 Good job for testing and great that you provide direct feedback!

010101

GreXXL I already mentioned this. Turn off the scraping setting and then his won’t happen. But, then if no OG tags, you won’t have images. Still, turning off the scraping setting works best for now.

GreXXL

010101 thanks - much better. But possibly it could be limited to just load one image - hopefully 🙂

clarkwinkelmann

Oops, definitely a bit of an oversight on my part, I should have seen that coming!

I'm using the same code to loop through images on both OpenGraph and the fallback crawler, so generally OpenGraph has a limited number of images, but fallback could find way more of them.

I'm not sure what the reasonable image count is, so I think I'll add this as configurable value. And probably apply the same value to both OpenGraph and fallback, in case you want to limit all of them to 1.

CyberGene

If I just paste an image link without any formatting, is it this extension that will render it? I guess not because it doesn’t seem like the image gets the dimension overlays. But it’s still rendered and even clickable and opens the image in a new tab… What other extension is taking precedence, if that’s the case? FoF Formatting? Is there any way of reordering what extension renders what type of raw links?

clarkwinkelmann

CyberGene that's AutoImage from FoF Formatting I would guess.

I wouldn't expect any conflict between the 2 extensions, because AutoLink only modifies the post parser and my extension only impacts the rendering templates.

Can you confirm there's still an issue when both my extension and AutoImage are used? I'll take a look if so

Imgur and other hosting websites have a full MediaEmbed template, in which case my extension won't do anything

CyberGene

clarkwinkelmann Can you confirm there's still an issue when both my extension and AutoImage are used? I'll take a look if so

No, no, sorry, there’s no issue. I’m just wondering if I still benefit from your extension’s ability to allocate the image dimensions, so that there are no page scroll jumps in loading. Frankly, it’s the main reason I use your extension but it’s a terrific functionality and I would like to make sure your extension takes precedence over FoF Formatting for any type of links that it can work with, even raw ones.

clarkwinkelmann

For users trying to use YouTube or Google Drive together with MediaEmbed, I have now published a new extension that can be used to enable only a sub-selection of MediaEmbed websites:

https://discuss.flarum.org/d/31404-selective-mediaembed

MediaEmbed will still have priority over Rich Embeds, but now you can disable those you don't want overridden.

CyberGene

Just found a small rendering issue. If the URL is too long it will be visualized outside the boundaries of the little rectangular frame that contains the preview:

I'm not sure if it has something to do with the fact it's a MP3 file that can't be previewed. Besides, I'm using the Inline Audio extension that shows a little play button, maybe it messes up with the Rich Embeds somehow?

clarkwinkelmann

CyberGene it's normal for that popup to appear even for links that can't be previewed, I added it because otherwise there's no way to access the refresh button in case that was a temporary error with the target website.

I will add something to prevent URLs going out of the screen.

010101

Customer feedback. 😉

For me, this works better than ever. But, I’ll admit, I leave most settings off. I may try turning on the proxy and scraping again one day. But, keeping the settings/features minimal, I’ve had no issues and it’s so fast! 😍

clarkwinkelmann

010101 thanks!

Just using the OpenGraph feature is perfectly fine!

The proxy features are only really necessary if you are using advanced security measures on your website like a CSP configuration that blocks external image loading.

I will release a cloud subscription in the near future that allows using all the advanced options without the need to configure any API tokens, and it will also come with a CDN domain to load images from to give a tiny performance improvement by stripping cookies out of the requests.

« Previous Page Next Page »